Collection API - #3
Conversation
alecbcs
left a comment
There was a problem hiding this comment.
Super nice job! This PR looks great. Just a couple points of feedback.
I also might suggest creating the sqlite db in the root of the repo and actually putting db/ under gantry/ instead of leaving it as its own top level component. This might fit a bit better depending on how we structure the components. I'd probably go for something like the following, but feel free to push back if you don't find that as easy to work with.
gantry/
db/
get.py
insert.py
clients/
prometheus.py
gitlab.py
models/
jobs.py
vms.py
routes/
collection.py
__main__.py
Co-authored-by: Alec Scott <scott112@llnl.gov>
I like this! Should I stick the |
|
Going to tackle testing in another PR to avoid adding too much more to this. marking this one as ready |
alecbcs
left a comment
There was a problem hiding this comment.
Big fan of the rewrite! Just a few small nitpicks neither of which are real blockers if you prefer keeping as is. Otherwise looks good to me!
This PR implements a webhook for the status change of Gitlab jobs. Build jobs are selected for processing, where a series of Prometheus queries are issued and data about the build and resource utilization are made available.
Adds:
POSTendpoint under/collect.Priorities:
All main functionality is implemented and I have removed the draft status from the PR. There are just a couple more things to do:
spack-infrastructure!733is merged, make sure that stack is being properly collected in the dataAlso, I realize that this PR is quite big, so I'm happy to break it up into smaller pieces.