Convert StackObjectsCount to int (#742)#743
Closed
ArchangelWTF wants to merge 3 commits into
Closed
Conversation
ArchangelWTF
force-pushed
the
convert-stackobjectscount-to-int
branch
from
d71fd80 to
5663c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A permanent fix for #742
This is currently in draft status as this has only changed the bare minimum, we should really consider if we even want to bother with this or just fix it with some more band-aid as this is at least another few hundred method changes deep to fully convert SPT to use StackObjectsCount's proper type
Also there is a lot of inconsistent typing for this in regards to the client, for example the handbook's pricing is a
floatwhich will cause us to have to do some pretty weird conversions in the server in order to accommodate that