Skip to content

fix: restore powershell_wmf reboot delay#199

Open
damacus wants to merge 1 commit intomainfrom
fix/powershell-wmf-reboot-delay
Open

fix: restore powershell_wmf reboot delay#199
damacus wants to merge 1 commit intomainfrom
fix/powershell-wmf-reboot-delay

Conversation

@damacus
Copy link
Copy Markdown
Member

@damacus damacus commented Apr 21, 2026

Summary:

  • add an explicit reboot_delay_mins property to powershell_wmf for delayed reboot requests
  • preserve the legacy reboot_timeout_seconds fallback when no explicit delay is set
  • document the new property and cover both paths in ChefSpec

Testing:

  • /opt/chef-workstation/embedded/bin/rspec --format documentation
  • cookstyle resources/powershell_wmf.rb spec/unit/resources/powershell_wmf_spec.rb

@damacus damacus requested a review from a team as a code owner April 21, 2026 09:23
@github-actions
Copy link
Copy Markdown

Slowest examples

Top 10 slowest examples (1.1 seconds, 44.16% of total time)
Example Description Time in seconds
spec/unit/resources/powershell_dsc_spec.rb:17 powershell_dsc is expected to install powershell_wmf "4.0" 0.14481
spec/unit/resources/powershell_lcm_spec.rb:27 powershell_lcm with action :enable is expected to create directory "Creating temporary directory to store LCM MOF files" 0.11872
spec/unit/resources/powershell_wmf_spec.rb:65 powershell_wmf when installing PowerShell 5.1 on Windows Server 2008 R2 is expected to include recipe "ms_dotnet::ms_dotnet4" 0.11377
spec/unit/resources/powershell_wmf_spec.rb:78 powershell_wmf when installing PowerShell 5.1 on Windows Server 2008 R2 is expected to equal true 0.11064
spec/unit/resources/powershell_lcm_spec.rb:26 powershell_lcm with action :enable is expected to create powershell_dsc "default" 0.10749
spec/unit/resources/powershell_wmf_spec.rb:20 powershell_wmf when installing PowerShell 2.0 on Windows Server 2012 is expected to install windows_feature "MicrosoftWindowsPowerShellV2" 0.10421
spec/unit/resources/powershell_wmf_spec.rb:66 powershell_wmf when installing PowerShell 5.1 on Windows Server 2008 R2 is expected to create remote_file "C:/Users/RUNNER~1/AppData/Local/Temp/d20260421-7708-rixk53\wmf51.zip" 0.10271
spec/unit/resources/powershell_wmf_spec.rb:72 powershell_wmf when installing PowerShell 5.1 on Windows Server 2008 R2 is expected to extract archive_file "C:/Users/RUNNER~1/AppData/Local/Temp/d20260421-7708-bt3ymd\wmf51.zip" 0.1014
spec/unit/resources/powershell_wmf_spec.rb:114 powershell_wmf when using the legacy reboot timeout override is expected to eq 2 0.1006
spec/unit/resources/powershell_wmf_spec.rb:98 powershell_wmf when requesting a delayed reboot with an explicit delay is expected to eq 5 0.09974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant