Upgrade Core to 56eab6ef118e9731df539d3a507db1c23241f911#673
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: Upgrades the vendored 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
| const auto result{ | ||
| std::to_chars(buffer.data(), buffer.data() + buffer.size(), value)}; | ||
| // This can't realistically happen on production given the buffer size | ||
| assert(result.ec == std::errc{}); |
There was a problem hiding this comment.
assert(result.ec == std::errc{}) is compiled out under NDEBUG, so if std::to_chars ever returns an error (e.g., unexpected value_too_large), this will still write buffer bytes based on result.ptr and can silently produce invalid output. Consider handling the non-success ec path in non-assert builds (even if it’s “not realistic”).
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark (linux/llvm)
Details
| Benchmark suite | Current: 4666270 | Previous: 4c9e913 | Ratio |
|---|---|---|---|
E2E_Compiler_adaptivecard |
64151560.88888807 ns/iter |
63991274.777777106 ns/iter |
1.00 |
E2E_Compiler_ansible_meta |
28938040.83333388 ns/iter |
29127852.791667406 ns/iter |
0.99 |
E2E_Compiler_aws_cdk |
377597.81098547357 ns/iter |
380996.3492927345 ns/iter |
0.99 |
E2E_Compiler_babelrc |
2578428.1567164087 ns/iter |
2595670.0371746244 ns/iter |
0.99 |
E2E_Compiler_clang_format |
18228654.394737244 ns/iter |
18424329.210523937 ns/iter |
0.99 |
E2E_Compiler_cmake_presets |
25688484.777777765 ns/iter |
25899422.962959725 ns/iter |
0.99 |
E2E_Compiler_code_climate |
2567907.485401361 ns/iter |
2604512.2044609454 ns/iter |
0.99 |
E2E_Compiler_cql2 |
12999460.2592597 ns/iter |
12816251.98181783 ns/iter |
1.01 |
E2E_Compiler_cspell |
22808362.13333449 ns/iter |
22650570.161288433 ns/iter |
1.01 |
E2E_Compiler_cypress |
3934255.9213484866 ns/iter |
3930427.631284828 ns/iter |
1.00 |
E2E_Compiler_deno |
7697527.8571429765 ns/iter |
7775707.977777478 ns/iter |
0.99 |
E2E_Compiler_dependabot |
3893204.2166667064 ns/iter |
3918116.5754189603 ns/iter |
0.99 |
E2E_Compiler_draft_04 |
2674162.1755724447 ns/iter |
2684037.9770113756 ns/iter |
1.00 |
E2E_Compiler_fabric_mod |
4731167.35810823 ns/iter |
4773011.417808305 ns/iter |
0.99 |
E2E_Compiler_geojson |
22235062.250000935 ns/iter |
22297248.29032142 ns/iter |
1.00 |
E2E_Compiler_gitpod_configuration |
4905596.669014015 ns/iter |
4920399.499999637 ns/iter |
1.00 |
E2E_Compiler_helm_chart_lock |
707694.5955510715 ns/iter |
711625.8302845636 ns/iter |
0.99 |
E2E_Compiler_importmap |
286070.2603912051 ns/iter |
290433.71884059306 ns/iter |
0.98 |
E2E_Compiler_jasmine |
1390523.4194175294 ns/iter |
1373021.78192522 ns/iter |
1.01 |
E2E_Compiler_jshintrc |
4342950.726707793 ns/iter |
4401085.622641758 ns/iter |
0.99 |
E2E_Compiler_jsconfig |
22588475.531250652 ns/iter |
22070466.999998927 ns/iter |
1.02 |
E2E_Compiler_krakend |
142725541.79999587 ns/iter |
145144588.60001013 ns/iter |
0.98 |
E2E_Compiler_lazygit |
33433476.52380977 ns/iter |
33747008.99999945 ns/iter |
0.99 |
E2E_Compiler_lerna |
1597384.842824632 ns/iter |
1603541.7609192997 ns/iter |
1.00 |
E2E_Compiler_nest_cli |
7431047.648935873 ns/iter |
7473911.010639226 ns/iter |
0.99 |
E2E_Compiler_omc |
158889582.5000094 ns/iter |
157594619.00000817 ns/iter |
1.01 |
E2E_Compiler_omnisharp |
6697922.380952886 ns/iter |
6762037.6153850155 ns/iter |
0.99 |
E2E_Compiler_openapi |
25095726.28571277 ns/iter |
25072563.892856743 ns/iter |
1.00 |
E2E_Compiler_pre_commit_hooks |
5299390.303030484 ns/iter |
5351817.442748378 ns/iter |
0.99 |
E2E_Compiler_pulumi |
4027151.6724137603 ns/iter |
4061909.9244187786 ns/iter |
0.99 |
E2E_Compiler_semantic_release |
1601892.8418708243 ns/iter |
1574218.5045045463 ns/iter |
1.02 |
E2E_Compiler_stale |
1553141.7522123498 ns/iter |
1560962.9149888193 ns/iter |
0.99 |
E2E_Compiler_stylecop |
6236142.561403455 ns/iter |
6203534.318584123 ns/iter |
1.01 |
E2E_Compiler_tmuxinator |
1924970.5840221627 ns/iter |
1939970.563535915 ns/iter |
0.99 |
E2E_Compiler_ui5 |
47316489.59999954 ns/iter |
48181080.428573094 ns/iter |
0.98 |
E2E_Compiler_ui5_manifest |
323462518.0000137 ns/iter |
322057141.00001615 ns/iter |
1.00 |
E2E_Compiler_unreal_engine_uproject |
4585314.71895445 ns/iter |
4761318.980132388 ns/iter |
0.96 |
E2E_Compiler_vercel |
12460176.642857084 ns/iter |
12528064.696427675 ns/iter |
0.99 |
E2E_Compiler_yamllint |
352157.06202722125 ns/iter |
352950.98334173183 ns/iter |
1.00 |
E2E_Evaluator_adaptivecard |
25233.46014992759 ns/iter |
25209.92162353621 ns/iter |
1.00 |
E2E_Evaluator_ansible_meta |
237344.50962512963 ns/iter |
236925.10315090755 ns/iter |
1.00 |
E2E_Evaluator_aws_cdk |
51961.30870475731 ns/iter |
50472.50201380877 ns/iter |
1.03 |
E2E_Evaluator_babelrc |
109414.94880599435 ns/iter |
107901.71454739188 ns/iter |
1.01 |
E2E_Evaluator_cerebrum_criminal_case |
1262710.8360071974 ns/iter |
1237363.8175311529 ns/iter |
1.02 |
E2E_Evaluator_clang_format |
125001.63710680701 ns/iter |
125486.33505246825 ns/iter |
1.00 |
E2E_Evaluator_cmake_presets |
4226067.783132562 ns/iter |
4405423.235668891 ns/iter |
0.96 |
E2E_Evaluator_code_climate |
179059.5446106217 ns/iter |
174713.2325754018 ns/iter |
1.02 |
E2E_Evaluator_cql2 |
209701.28469539378 ns/iter |
202188.84557766173 ns/iter |
1.04 |
E2E_Evaluator_cspell |
570975.0976594151 ns/iter |
566632.4366987469 ns/iter |
1.01 |
E2E_Evaluator_cypress |
192233.76342604915 ns/iter |
188439.89935414644 ns/iter |
1.02 |
E2E_Evaluator_deno |
317128.2140238672 ns/iter |
314355.9135304567 ns/iter |
1.01 |
E2E_Evaluator_dependabot |
423500.1945121938 ns/iter |
426539.70715171983 ns/iter |
0.99 |
E2E_Evaluator_draft_04 |
7662200.752808908 ns/iter |
7899136.370785905 ns/iter |
0.97 |
E2E_Evaluator_fabric_mod |
703377.0597770765 ns/iter |
683187.5652600032 ns/iter |
1.03 |
E2E_Evaluator_geojson |
15516301.622220553 ns/iter |
16082667.954546796 ns/iter |
0.96 |
E2E_Evaluator_gitpod_configuration |
233877.55791961978 ns/iter |
238186.1773761655 ns/iter |
0.98 |
E2E_Evaluator_helm_chart_lock |
357711.33590142324 ns/iter |
360330.00611619465 ns/iter |
0.99 |
E2E_Evaluator_importmap |
50772.94619999293 ns/iter |
49144.827139761124 ns/iter |
1.03 |
E2E_Evaluator_jasmine |
109091.61797405768 ns/iter |
107520.1663384268 ns/iter |
1.01 |
E2E_Evaluator_jshintrc |
1218109.6643478114 ns/iter |
1204437.4828179441 ns/iter |
1.01 |
E2E_Evaluator_jsconfig |
429904.995086 ns/iter |
427896.33787127136 ns/iter |
1.00 |
E2E_Evaluator_krakend |
213780.09557687628 ns/iter |
207611.36580341094 ns/iter |
1.03 |
E2E_Evaluator_lazygit |
148574.6299262403 ns/iter |
144627.68813630476 ns/iter |
1.03 |
E2E_Evaluator_lerna |
149049.6500515108 ns/iter |
144002.22122415583 ns/iter |
1.04 |
E2E_Evaluator_nest_cli |
187116.97454931895 ns/iter |
181885.65878379307 ns/iter |
1.03 |
E2E_Evaluator_omc |
20340.352361634683 ns/iter |
19764.63987456394 ns/iter |
1.03 |
E2E_Evaluator_omnisharp |
609053.5270506662 ns/iter |
603320.8706293697 ns/iter |
1.01 |
E2E_Evaluator_openapi |
14152571.653061833 ns/iter |
15982987.021741139 ns/iter |
0.89 |
E2E_Evaluator_pre_commit_hooks |
478254.15947982454 ns/iter |
500121.3440000356 ns/iter |
0.96 |
E2E_Evaluator_pulumi |
702966.3289340256 ns/iter |
687556.9890656443 ns/iter |
1.02 |
E2E_Evaluator_semantic_release |
98852.21270439266 ns/iter |
96504.93458978875 ns/iter |
1.02 |
E2E_Evaluator_stale |
156085.37950077694 ns/iter |
150435.99616611892 ns/iter |
1.04 |
E2E_Evaluator_stylecop |
285721.37825734646 ns/iter |
285589.8768916027 ns/iter |
1.00 |
E2E_Evaluator_tmuxinator |
99565.04229350825 ns/iter |
97011.17236131495 ns/iter |
1.03 |
E2E_Evaluator_ui5 |
522453.1691842451 ns/iter |
509074.45547445735 ns/iter |
1.03 |
E2E_Evaluator_ui5_manifest |
2574741.1814816385 ns/iter |
2546786.535971422 ns/iter |
1.01 |
E2E_Evaluator_unreal_engine_uproject |
430545.95601709257 ns/iter |
434109.8745318219 ns/iter |
0.99 |
E2E_Evaluator_vercel |
325263.0023116261 ns/iter |
327182.1934137361 ns/iter |
0.99 |
E2E_Evaluator_yamllint |
8899.12232076005 ns/iter |
8605.69327471614 ns/iter |
1.03 |
Micro_Draft4_Meta_1_No_Callback |
183.48718272829902 ns/iter |
197.9991941752605 ns/iter |
0.93 |
Micro_Draft4_Required_Properties |
864.045323136511 ns/iter |
832.7859229750521 ns/iter |
1.04 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
22.804108373429788 ns/iter |
23.119162276984355 ns/iter |
0.99 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
11.525419612484733 ns/iter |
11.565841209870152 ns/iter |
1.00 |
Micro_Draft4_Items_Schema |
304.44580713289815 ns/iter |
288.2044319540098 ns/iter |
1.06 |
Micro_Draft4_Nested_Object |
1.8117045034562556 ns/iter |
1.8026527233326872 ns/iter |
1.01 |
Micro_Draft4_Properties_Triad_Optional |
334.7814301421476 ns/iter |
326.4807331116416 ns/iter |
1.03 |
Micro_Draft4_Properties_Triad_Closed |
277.06308895420443 ns/iter |
268.62859381750746 ns/iter |
1.03 |
Micro_Draft4_Properties_Triad_Required |
356.636536020967 ns/iter |
353.9062002994841 ns/iter |
1.01 |
Micro_Draft4_Properties_Closed |
58.01147997664183 ns/iter |
57.56387749218424 ns/iter |
1.01 |
Micro_Draft4_Non_Recursive_Ref |
11.621245111112678 ns/iter |
14.33918563681435 ns/iter |
0.81 |
Micro_Draft4_Pattern_Properties_True |
191.36343188882455 ns/iter |
193.335158558839 ns/iter |
0.99 |
Micro_Draft4_Ref_To_Single_Property |
11.526309163763809 ns/iter |
11.514007712334308 ns/iter |
1.00 |
Micro_Draft4_Additional_Properties_Type |
24.975184185432653 ns/iter |
28.3834205720656 ns/iter |
0.88 |
Micro_Draft4_Nested_Oneof |
56.34119802199779 ns/iter |
57.91371987962046 ns/iter |
0.97 |
Micro_Draft4_Short_Enum |
11.826685479824892 ns/iter |
11.829164159876086 ns/iter |
1.00 |
Micro_Draft4_Long_Enum |
14.33281041653791 ns/iter |
14.947235766476865 ns/iter |
0.96 |
Micro_Draft4_Long_Enum_Short_Strings |
11.825495106969894 ns/iter |
11.827965023739795 ns/iter |
1.00 |
Micro_Draft4_Type_Object |
3.4233489905830528 ns/iter |
3.426928524107685 ns/iter |
1.00 |
Micro_Draft4_Ref_Single_100 |
2405564.8137928545 ns/iter |
2382690.822525885 ns/iter |
1.01 |
Micro_Draft4_Compile_Ref_Many_Nested |
1727263.5693069617 ns/iter |
1721203.6348041135 ns/iter |
1.00 |
Micro_Draft4_Compile_Wrap |
2394723.160958785 ns/iter |
2384605.374149431 ns/iter |
1.00 |
Micro_Draft6_Property_Names |
121.09317062276646 ns/iter |
134.43593655305452 ns/iter |
0.90 |
Micro_Draft6_Compile_FHIR |
14537582917.00001 ns/iter |
14114814943.000055 ns/iter |
1.03 |
Micro_Draft7_If_Then_Else |
27.315567356340125 ns/iter |
23.986085730380488 ns/iter |
1.14 |
Micro_2019_09_Unevaluated_Properties |
29.278529543047455 ns/iter |
28.76505824998013 ns/iter |
1.02 |
Micro_2019_09_Compile_Wrap |
304706688.99999964 ns/iter |
329743566.4999853 ns/iter |
0.92 |
Micro_2019_09_KrakenD_Linter_Check |
1184638810.000024 ns/iter |
1198691959.0000298 ns/iter |
0.99 |
Micro_2019_09_KrakenD_Linter_Apply |
10730577132.999884 ns/iter |
10774951127.000008 ns/iter |
1.00 |
Micro_2020_12_Dynamic_Ref |
233.06561637594564 ns/iter |
224.16298582429647 ns/iter |
1.04 |
Micro_2020_12_Dynamic_Ref_Single |
3.4277077397033744 ns/iter |
3.4265724846776995 ns/iter |
1.00 |
Micro_2020_12_Simple_Output_Mask |
78166.69386429344 ns/iter |
80281.14895088074 ns/iter |
0.97 |
Micro_2020_12_Simple_Output_Annotations |
138790.7163134827 ns/iter |
139696.15829960056 ns/iter |
0.99 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
1103494.6324921881 ns/iter |
1132580.3512658214 ns/iter |
0.97 |
Micro_2020_12_Exhaustive_Deep_Numeric |
8138.498141051097 ns/iter |
8174.496118102758 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
174077.21094725904 ns/iter |
179930.63264249652 ns/iter |
0.97 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
22897.84301683386 ns/iter |
22543.717717909774 ns/iter |
1.02 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
142.9572497122839 ns/iter |
143.30516706924246 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
4794.758120244319 ns/iter |
4899.192369844461 ns/iter |
0.98 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (macos/llvm)
Details
| Benchmark suite | Current: 4666270 | Previous: 4c9e913 | Ratio |
|---|---|---|---|
E2E_Compiler_adaptivecard |
61024745.80000035 ns/iter |
59119552.08333097 ns/iter |
1.03 |
E2E_Compiler_ansible_meta |
25050065.464284897 ns/iter |
28137972.249998216 ns/iter |
0.89 |
E2E_Compiler_aws_cdk |
280642.5952856271 ns/iter |
297696.25729775405 ns/iter |
0.94 |
E2E_Compiler_babelrc |
2210433.1253918433 ns/iter |
2275018.9516130146 ns/iter |
0.97 |
E2E_Compiler_clang_format |
15173982.422220435 ns/iter |
15579723.404255945 ns/iter |
0.97 |
E2E_Compiler_cmake_presets |
26775047.851852257 ns/iter |
26885165.111113768 ns/iter |
1.00 |
E2E_Compiler_code_climate |
2434589.425170119 ns/iter |
2258033.6579804868 ns/iter |
1.08 |
E2E_Compiler_cql2 |
12570442.982454902 ns/iter |
12409075.819671104 ns/iter |
1.01 |
E2E_Compiler_cspell |
23320364.258064467 ns/iter |
20615403.57142673 ns/iter |
1.13 |
E2E_Compiler_cypress |
3700473.9052630803 ns/iter |
3992863.473403899 ns/iter |
0.93 |
E2E_Compiler_deno |
8120925.563106831 ns/iter |
7283047.445543891 ns/iter |
1.12 |
E2E_Compiler_dependabot |
5578762.784091267 ns/iter |
3869751.344086336 ns/iter |
1.44 |
E2E_Compiler_draft_04 |
2421969.8938359 ns/iter |
2331012.89250829 ns/iter |
1.04 |
E2E_Compiler_fabric_mod |
4147523.973117782 ns/iter |
4003339.3267974425 ns/iter |
1.04 |
E2E_Compiler_geojson |
27206551.269229677 ns/iter |
24004110.225805122 ns/iter |
1.13 |
E2E_Compiler_gitpod_configuration |
4309820.280000167 ns/iter |
4546955.955695869 ns/iter |
0.95 |
E2E_Compiler_helm_chart_lock |
607440.471625777 ns/iter |
579590.3931860009 ns/iter |
1.05 |
E2E_Compiler_importmap |
285953.12314022525 ns/iter |
247208.85579935895 ns/iter |
1.16 |
E2E_Compiler_jasmine |
2204997.9792147735 ns/iter |
1237641.5877743398 ns/iter |
1.78 |
E2E_Compiler_jshintrc |
4824601.599999859 ns/iter |
3737123.036649596 ns/iter |
1.29 |
E2E_Compiler_jsconfig |
19970536.914284565 ns/iter |
21464372.52941148 ns/iter |
0.93 |
E2E_Compiler_krakend |
132453858.40000382 ns/iter |
146422858.4000011 ns/iter |
0.90 |
E2E_Compiler_lazygit |
33693279.76190561 ns/iter |
42699478.1052635 ns/iter |
0.79 |
E2E_Compiler_lerna |
1413932.6972657517 ns/iter |
1580339.2262626523 ns/iter |
0.89 |
E2E_Compiler_nest_cli |
6553090.211009852 ns/iter |
7221967.640776994 ns/iter |
0.91 |
E2E_Compiler_omc |
177987458.24998719 ns/iter |
190501781.24999207 ns/iter |
0.93 |
E2E_Compiler_omnisharp |
6491118.589743121 ns/iter |
6505970.058252317 ns/iter |
1.00 |
E2E_Compiler_openapi |
24011170.709675223 ns/iter |
23158587.354839344 ns/iter |
1.04 |
E2E_Compiler_pre_commit_hooks |
5054743.055555693 ns/iter |
4494961.999999908 ns/iter |
1.12 |
E2E_Compiler_pulumi |
3724747.7336959294 ns/iter |
3427306.1791043407 ns/iter |
1.09 |
E2E_Compiler_semantic_release |
1704829.1746642163 ns/iter |
1317925.1176470404 ns/iter |
1.29 |
E2E_Compiler_stale |
1872694.0247251359 ns/iter |
1410510.358070567 ns/iter |
1.33 |
E2E_Compiler_stylecop |
6083527.38095272 ns/iter |
5838911.417322916 ns/iter |
1.04 |
E2E_Compiler_tmuxinator |
1684650.424594007 ns/iter |
1687629.3901346766 ns/iter |
1.00 |
E2E_Compiler_ui5 |
59121731.09090252 ns/iter |
97568291.69999719 ns/iter |
0.61 |
E2E_Compiler_ui5_manifest |
344392042.00003815 ns/iter |
410527166.5000032 ns/iter |
0.84 |
E2E_Compiler_unreal_engine_uproject |
4610778.613333271 ns/iter |
4422523.4848481985 ns/iter |
1.04 |
E2E_Compiler_vercel |
13729928.688889636 ns/iter |
13071860.849056562 ns/iter |
1.05 |
E2E_Compiler_yamllint |
269021.94862864725 ns/iter |
266702.66805926064 ns/iter |
1.01 |
E2E_Evaluator_adaptivecard |
20525.569055241886 ns/iter |
19918.528395555175 ns/iter |
1.03 |
E2E_Evaluator_ansible_meta |
170691.29448653205 ns/iter |
198173.31957547824 ns/iter |
0.86 |
E2E_Evaluator_aws_cdk |
35347.82330017197 ns/iter |
34782.6797145996 ns/iter |
1.02 |
E2E_Evaluator_babelrc |
83651.57978348313 ns/iter |
86601.82786413578 ns/iter |
0.97 |
E2E_Evaluator_cerebrum_criminal_case |
1151697.3641024518 ns/iter |
952592.8123393208 ns/iter |
1.21 |
E2E_Evaluator_clang_format |
104305.57231512462 ns/iter |
106761.45549271136 ns/iter |
0.98 |
E2E_Evaluator_cmake_presets |
3594086.513888644 ns/iter |
4300658.254807606 ns/iter |
0.84 |
E2E_Evaluator_code_climate |
130681.35202225694 ns/iter |
123470.88569910261 ns/iter |
1.06 |
E2E_Evaluator_cql2 |
151597.69591562188 ns/iter |
144054.43589744094 ns/iter |
1.05 |
E2E_Evaluator_cspell |
442551.8812462919 ns/iter |
410045.5351788165 ns/iter |
1.08 |
E2E_Evaluator_cypress |
149684.95243104972 ns/iter |
143278.7721620487 ns/iter |
1.04 |
E2E_Evaluator_deno |
225664.6167870494 ns/iter |
215513.4900241968 ns/iter |
1.05 |
E2E_Evaluator_dependabot |
323824.7214484289 ns/iter |
318530.3030303396 ns/iter |
1.02 |
E2E_Evaluator_draft_04 |
5472922.222222425 ns/iter |
5241800.43609013 ns/iter |
1.04 |
E2E_Evaluator_fabric_mod |
507738.7499999304 ns/iter |
525732.5210781322 ns/iter |
0.97 |
E2E_Evaluator_geojson |
10230920.7451009 ns/iter |
10434090.72580685 ns/iter |
0.98 |
E2E_Evaluator_gitpod_configuration |
191094.30368763948 ns/iter |
166465.59530284864 ns/iter |
1.15 |
E2E_Evaluator_helm_chart_lock |
234794.2051376801 ns/iter |
209700.1046895739 ns/iter |
1.12 |
E2E_Evaluator_importmap |
33576.37504530087 ns/iter |
30473.244832861124 ns/iter |
1.10 |
E2E_Evaluator_jasmine |
82471.23856098404 ns/iter |
87245.67543148286 ns/iter |
0.95 |
E2E_Evaluator_jshintrc |
912270.955752392 ns/iter |
932684.5394736582 ns/iter |
0.98 |
E2E_Evaluator_jsconfig |
336671.02447713097 ns/iter |
303398.86072667205 ns/iter |
1.11 |
E2E_Evaluator_krakend |
151921.10462927126 ns/iter |
147222.78872426 ns/iter |
1.03 |
E2E_Evaluator_lazygit |
110882.48156471521 ns/iter |
104392.74182226374 ns/iter |
1.06 |
E2E_Evaluator_lerna |
126451.60531090104 ns/iter |
116221.54936332938 ns/iter |
1.09 |
E2E_Evaluator_nest_cli |
132168.62610074456 ns/iter |
129613.1694945685 ns/iter |
1.02 |
E2E_Evaluator_omc |
15701.47099486743 ns/iter |
14565.433335409238 ns/iter |
1.08 |
E2E_Evaluator_omnisharp |
569816.8923275952 ns/iter |
453568.90320549236 ns/iter |
1.26 |
E2E_Evaluator_openapi |
9490987.847224612 ns/iter |
8125585.937497703 ns/iter |
1.17 |
E2E_Evaluator_pre_commit_hooks |
332673.49624070345 ns/iter |
325988.57655500795 ns/iter |
1.02 |
E2E_Evaluator_pulumi |
520907.33399995766 ns/iter |
511792.4925688689 ns/iter |
1.02 |
E2E_Evaluator_semantic_release |
72015.6575165902 ns/iter |
68689.33409002468 ns/iter |
1.05 |
E2E_Evaluator_stale |
121795.61903288278 ns/iter |
108539.94516968324 ns/iter |
1.12 |
E2E_Evaluator_stylecop |
215582.9935972437 ns/iter |
181595.8494178179 ns/iter |
1.19 |
E2E_Evaluator_tmuxinator |
74731.28708867112 ns/iter |
67756.5478487474 ns/iter |
1.10 |
E2E_Evaluator_ui5 |
336869.6373206222 ns/iter |
330609.3850687339 ns/iter |
1.02 |
E2E_Evaluator_ui5_manifest |
1809790.780142208 ns/iter |
1674224.8883931309 ns/iter |
1.08 |
E2E_Evaluator_unreal_engine_uproject |
310752.5504914995 ns/iter |
307614.89524647384 ns/iter |
1.01 |
E2E_Evaluator_vercel |
215896.95362321884 ns/iter |
217831.0126856589 ns/iter |
0.99 |
E2E_Evaluator_yamllint |
5864.896100784694 ns/iter |
5924.109184054375 ns/iter |
0.99 |
Micro_Draft4_Meta_1_No_Callback |
137.49328698344945 ns/iter |
129.64513165038568 ns/iter |
1.06 |
Micro_Draft4_Required_Properties |
628.4064009354543 ns/iter |
631.0639792823445 ns/iter |
1.00 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
19.068473063570146 ns/iter |
18.28806231852537 ns/iter |
1.04 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
7.147927419935759 ns/iter |
7.142519899218306 ns/iter |
1.00 |
Micro_Draft4_Items_Schema |
257.4155805125216 ns/iter |
254.2251908397138 ns/iter |
1.01 |
Micro_Draft4_Nested_Object |
0.6776257210659259 ns/iter |
0.7077542497863336 ns/iter |
0.96 |
Micro_Draft4_Properties_Triad_Optional |
200.40302952084107 ns/iter |
200.84596895472933 ns/iter |
1.00 |
Micro_Draft4_Properties_Triad_Closed |
165.05669118758726 ns/iter |
166.2109845773491 ns/iter |
0.99 |
Micro_Draft4_Properties_Triad_Required |
210.54432756044477 ns/iter |
210.9569022774159 ns/iter |
1.00 |
Micro_Draft4_Properties_Closed |
37.674638091830964 ns/iter |
37.5051765944608 ns/iter |
1.00 |
Micro_Draft4_Non_Recursive_Ref |
12.578853104252676 ns/iter |
12.590371322076807 ns/iter |
1.00 |
Micro_Draft4_Pattern_Properties_True |
144.55280720809813 ns/iter |
142.52955117792877 ns/iter |
1.01 |
Micro_Draft4_Ref_To_Single_Property |
7.468919277645978 ns/iter |
7.139989770794643 ns/iter |
1.05 |
Micro_Draft4_Additional_Properties_Type |
25.75589307179601 ns/iter |
25.249765821131785 ns/iter |
1.02 |
Micro_Draft4_Nested_Oneof |
40.2035753686127 ns/iter |
40.223959894712635 ns/iter |
1.00 |
Micro_Draft4_Short_Enum |
4.9317513988684185 ns/iter |
4.965358597527901 ns/iter |
0.99 |
Micro_Draft4_Long_Enum |
9.817147800969266 ns/iter |
9.806330829846239 ns/iter |
1.00 |
Micro_Draft4_Long_Enum_Short_Strings |
6.408741671563822 ns/iter |
6.4647288656569355 ns/iter |
0.99 |
Micro_Draft4_Type_Object |
2.149020325294917 ns/iter |
2.1538952136774516 ns/iter |
1.00 |
Micro_Draft4_Ref_Single_100 |
1706175.1446080918 ns/iter |
1718116.4974489342 ns/iter |
0.99 |
Micro_Draft4_Compile_Ref_Many_Nested |
1314755.133802877 ns/iter |
1278424.5495494942 ns/iter |
1.03 |
Micro_Draft4_Compile_Wrap |
2199453.8690474234 ns/iter |
2068777.4077382907 ns/iter |
1.06 |
Micro_Draft6_Property_Names |
94.99175902597888 ns/iter |
94.74797270133466 ns/iter |
1.00 |
Micro_Draft6_Compile_FHIR |
8976257916.000122 ns/iter |
8062502499.999937 ns/iter |
1.11 |
Micro_Draft7_If_Then_Else |
17.490236653605315 ns/iter |
17.126397092735004 ns/iter |
1.02 |
Micro_2019_09_Unevaluated_Properties |
25.65752435262975 ns/iter |
25.670188928825006 ns/iter |
1.00 |
Micro_2019_09_Compile_Wrap |
374574687.50005776 ns/iter |
316676312.5000216 ns/iter |
1.18 |
Micro_2019_09_KrakenD_Linter_Check |
725419666.000107 ns/iter |
646250332.9998981 ns/iter |
1.12 |
Micro_2019_09_KrakenD_Linter_Apply |
5622081791.99979 ns/iter |
5505891958.00012 ns/iter |
1.02 |
Micro_2020_12_Dynamic_Ref |
199.76555453484676 ns/iter |
185.17562159431972 ns/iter |
1.08 |
Micro_2020_12_Dynamic_Ref_Single |
2.2531807041943006 ns/iter |
2.1608499275840014 ns/iter |
1.04 |
Micro_2020_12_Simple_Output_Mask |
69341.75361748604 ns/iter |
69230.05148237667 ns/iter |
1.00 |
Micro_2020_12_Simple_Output_Annotations |
114309.10626527207 ns/iter |
113237.38205335064 ns/iter |
1.01 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
832487.0107913101 ns/iter |
816721.0339976022 ns/iter |
1.02 |
Micro_2020_12_Exhaustive_Deep_Numeric |
5446.443034031147 ns/iter |
5274.842017634313 ns/iter |
1.03 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
117770.31439075943 ns/iter |
117791.20912161654 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
14674.739453836759 ns/iter |
14386.269219811287 ns/iter |
1.02 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
92.6811107178989 ns/iter |
93.54346667329152 ns/iter |
0.99 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
4785.44721312393 ns/iter |
4767.37345189634 ns/iter |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Benchmark (linux/gcc)
Details
| Benchmark suite | Current: 4666270 | Previous: 4c9e913 | Ratio |
|---|---|---|---|
Micro_2020_12_Dynamic_Ref |
243.49591741363713 ns/iter |
266.94140503853555 ns/iter |
0.91 |
Micro_2020_12_Dynamic_Ref_Single |
4.9821694504121625 ns/iter |
4.688965684790625 ns/iter |
1.06 |
Micro_2020_12_Simple_Output_Mask |
84451.93589283203 ns/iter |
83375.06269076202 ns/iter |
1.01 |
Micro_2020_12_Simple_Output_Annotations |
147284.63871504684 ns/iter |
144948.81485312697 ns/iter |
1.02 |
Micro_2020_12_Compile_NonCircular_Shared_Refs |
1238510.4773519004 ns/iter |
1188837.5765305664 ns/iter |
1.04 |
Micro_2020_12_Exhaustive_Deep_Numeric |
8355.843664096203 ns/iter |
8241.141603529217 ns/iter |
1.01 |
Micro_2020_12_Exhaustive_Deep_Numeric_SimpleOutput |
169793.72200679575 ns/iter |
169189.4745519715 ns/iter |
1.00 |
Micro_2020_12_Exhaustive_Deep_Numeric_TraceOutput |
25968.209830628788 ns/iter |
25730.991575925204 ns/iter |
1.01 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail |
135.7305496070638 ns/iter |
125.28947060893513 ns/iter |
1.08 |
Micro_2020_12_Exhaustive_Deep_Numeric_Fail_SimpleOutput |
5234.038482509734 ns/iter |
5142.417589207374 ns/iter |
1.02 |
Micro_2019_09_Unevaluated_Properties |
31.475822026802827 ns/iter |
31.54891479350766 ns/iter |
1.00 |
Micro_2019_09_Compile_Wrap |
311397793.9999586 ns/iter |
299361317.4999155 ns/iter |
1.04 |
Micro_2019_09_KrakenD_Linter_Check |
1251195707.000079 ns/iter |
1237186051.99997 ns/iter |
1.01 |
Micro_2019_09_KrakenD_Linter_Apply |
11081570709.000061 ns/iter |
10948817187.000032 ns/iter |
1.01 |
Micro_Draft7_If_Then_Else |
26.484836097296366 ns/iter |
25.876746759710606 ns/iter |
1.02 |
Micro_Draft6_Property_Names |
142.46619670224766 ns/iter |
142.61778498540252 ns/iter |
1.00 |
Micro_Draft6_Compile_FHIR |
14173974935.999922 ns/iter |
14418320344.999983 ns/iter |
0.98 |
Micro_Draft4_Meta_1_No_Callback |
165.31031101538517 ns/iter |
189.21310615935263 ns/iter |
0.87 |
Micro_Draft4_Required_Properties |
816.2920114309643 ns/iter |
815.4259908327459 ns/iter |
1.00 |
Micro_Draft4_Many_Optional_Properties_Minimal_Match |
22.10280918375672 ns/iter |
21.653125944669373 ns/iter |
1.02 |
Micro_Draft4_Few_Optional_Properties_Minimal_Match |
13.09426105411357 ns/iter |
13.391317188885553 ns/iter |
0.98 |
Micro_Draft4_Items_Schema |
334.5000468861316 ns/iter |
387.5744155455865 ns/iter |
0.86 |
Micro_Draft4_Nested_Object |
1.8759104619594487 ns/iter |
1.8683686708145988 ns/iter |
1.00 |
Micro_Draft4_Properties_Triad_Optional |
546.069744943147 ns/iter |
490.85143161953755 ns/iter |
1.11 |
Micro_Draft4_Properties_Triad_Closed |
438.81898087776244 ns/iter |
342.98976575287793 ns/iter |
1.28 |
Micro_Draft4_Properties_Triad_Required |
582.9512278521103 ns/iter |
475.9208078095806 ns/iter |
1.22 |
Micro_Draft4_Properties_Closed |
61.04702306310861 ns/iter |
62.968659748850364 ns/iter |
0.97 |
Micro_Draft4_Non_Recursive_Ref |
9.653976139224838 ns/iter |
9.648296369840683 ns/iter |
1.00 |
Micro_Draft4_Pattern_Properties_True |
219.05476267666242 ns/iter |
232.26050007948803 ns/iter |
0.94 |
Micro_Draft4_Ref_To_Single_Property |
13.099318196409145 ns/iter |
13.789829522386647 ns/iter |
0.95 |
Micro_Draft4_Additional_Properties_Type |
14.946234323475679 ns/iter |
14.937193434225044 ns/iter |
1.00 |
Micro_Draft4_Nested_Oneof |
65.41843025821947 ns/iter |
66.90141582498168 ns/iter |
0.98 |
Micro_Draft4_Short_Enum |
14.792204513759279 ns/iter |
14.675135977716657 ns/iter |
1.01 |
Micro_Draft4_Long_Enum |
14.038200593839614 ns/iter |
14.337267872789303 ns/iter |
0.98 |
Micro_Draft4_Long_Enum_Short_Strings |
14.642312213296172 ns/iter |
14.703424537568695 ns/iter |
1.00 |
Micro_Draft4_Type_Object |
4.670510158901125 ns/iter |
4.9789239812414205 ns/iter |
0.94 |
Micro_Draft4_Ref_Single_100 |
2566718.7802203745 ns/iter |
2507316.720429961 ns/iter |
1.02 |
Micro_Draft4_Compile_Ref_Many_Nested |
1856434.4562336295 ns/iter |
1812414.2351422587 ns/iter |
1.02 |
Micro_Draft4_Compile_Wrap |
2642940.1278197216 ns/iter |
2638583.812499713 ns/iter |
1.00 |
E2E_Compiler_adaptivecard |
67226963.99999677 ns/iter |
64372072.999999955 ns/iter |
1.04 |
E2E_Compiler_ansible_meta |
31437056.8636274 ns/iter |
29860761.624992922 ns/iter |
1.05 |
E2E_Compiler_aws_cdk |
427048.49507994106 ns/iter |
403640.93356446666 ns/iter |
1.06 |
E2E_Compiler_babelrc |
2849548.1341464464 ns/iter |
2737482.6770430114 ns/iter |
1.04 |
E2E_Compiler_clang_format |
20044218.400003694 ns/iter |
19201826.729730215 ns/iter |
1.04 |
E2E_Compiler_cmake_presets |
27833907.240001284 ns/iter |
26833913.807693604 ns/iter |
1.04 |
E2E_Compiler_code_climate |
2871210.2016461096 ns/iter |
2736561.410852683 ns/iter |
1.05 |
E2E_Compiler_cql2 |
14190145.759998813 ns/iter |
14075388.76000217 ns/iter |
1.01 |
E2E_Compiler_cspell |
24452921.344830208 ns/iter |
23833614.37931195 ns/iter |
1.03 |
E2E_Compiler_cypress |
4232596.684848679 ns/iter |
4149020.8284021877 ns/iter |
1.02 |
E2E_Compiler_deno |
8391882.024096662 ns/iter |
8292681.149426024 ns/iter |
1.01 |
E2E_Compiler_dependabot |
4311425.640243514 ns/iter |
4170366.905324992 ns/iter |
1.03 |
E2E_Compiler_draft_04 |
2994277.726495647 ns/iter |
2884198.539094889 ns/iter |
1.04 |
E2E_Compiler_fabric_mod |
5245436.574626576 ns/iter |
5108527.89927916 ns/iter |
1.03 |
E2E_Compiler_geojson |
24569067.53571632 ns/iter |
23489247.133329626 ns/iter |
1.05 |
E2E_Compiler_gitpod_configuration |
5465717.453844613 ns/iter |
5187692.283582814 ns/iter |
1.05 |
E2E_Compiler_helm_chart_lock |
778974.8813188403 ns/iter |
738671.9694094138 ns/iter |
1.05 |
E2E_Compiler_importmap |
320234.602920974 ns/iter |
304085.2968750032 ns/iter |
1.05 |
E2E_Compiler_jasmine |
1500389.4089937794 ns/iter |
1451716.9375001988 ns/iter |
1.03 |
E2E_Compiler_jshintrc |
4816922.643835699 ns/iter |
4580737.624998596 ns/iter |
1.05 |
E2E_Compiler_jsconfig |
24179053.06896469 ns/iter |
23001393.166669004 ns/iter |
1.05 |
E2E_Compiler_krakend |
158396057.9999939 ns/iter |
142163861.60001093 ns/iter |
1.11 |
E2E_Compiler_lazygit |
37115939.84211216 ns/iter |
35037883.400002554 ns/iter |
1.06 |
E2E_Compiler_lerna |
1800586.0153064588 ns/iter |
1717886.0999997705 ns/iter |
1.05 |
E2E_Compiler_nest_cli |
8266490.25882355 ns/iter |
7865638.112360593 ns/iter |
1.05 |
E2E_Compiler_omc |
179886285.2500065 ns/iter |
160633031.2499722 ns/iter |
1.12 |
E2E_Compiler_omnisharp |
7440082.042103313 ns/iter |
7036554.666667437 ns/iter |
1.06 |
E2E_Compiler_openapi |
28205583.959997967 ns/iter |
26491962.50000002 ns/iter |
1.06 |
E2E_Compiler_pre_commit_hooks |
5908891.663865757 ns/iter |
5561040.0476188455 ns/iter |
1.06 |
E2E_Compiler_pulumi |
4518658.993588769 ns/iter |
4319527.97546092 ns/iter |
1.05 |
E2E_Compiler_semantic_release |
1750599.8668339867 ns/iter |
1668921.369928241 ns/iter |
1.05 |
E2E_Compiler_stale |
1709278.6682929373 ns/iter |
1648595.93647099 ns/iter |
1.04 |
E2E_Compiler_stylecop |
6510126.462962438 ns/iter |
6171831.876104763 ns/iter |
1.05 |
E2E_Compiler_tmuxinator |
2169738.925465975 ns/iter |
2080089.6834323243 ns/iter |
1.04 |
E2E_Compiler_ui5 |
52280183.69231134 ns/iter |
48628559.28570298 ns/iter |
1.08 |
E2E_Compiler_ui5_manifest |
355262630.9999596 ns/iter |
321512394.00002396 ns/iter |
1.10 |
E2E_Compiler_unreal_engine_uproject |
5091739.39130433 ns/iter |
4835470.434482917 ns/iter |
1.05 |
E2E_Compiler_vercel |
13475761.596151432 ns/iter |
13110712.148145637 ns/iter |
1.03 |
E2E_Compiler_yamllint |
392571.4696628235 ns/iter |
373392.0856838736 ns/iter |
1.05 |
E2E_Evaluator_adaptivecard |
24042.262028767807 ns/iter |
23472.18468376769 ns/iter |
1.02 |
E2E_Evaluator_ansible_meta |
252781.174024131 ns/iter |
249356.32652336918 ns/iter |
1.01 |
E2E_Evaluator_aws_cdk |
53285.39634146472 ns/iter |
51414.81476539886 ns/iter |
1.04 |
E2E_Evaluator_babelrc |
111149.77947293657 ns/iter |
102795.16291810399 ns/iter |
1.08 |
E2E_Evaluator_cerebrum_criminal_case |
1324631.9771866086 ns/iter |
1335485.256120732 ns/iter |
0.99 |
E2E_Evaluator_clang_format |
109226.50475134753 ns/iter |
107695.24899097632 ns/iter |
1.01 |
E2E_Evaluator_cmake_presets |
5986315.646017893 ns/iter |
4461007.547170714 ns/iter |
1.34 |
E2E_Evaluator_code_climate |
189369.90097929985 ns/iter |
185224.00052711097 ns/iter |
1.02 |
E2E_Evaluator_cql2 |
221216.05644903108 ns/iter |
223323.93101269018 ns/iter |
0.99 |
E2E_Evaluator_cspell |
560317.651649279 ns/iter |
547113.6225218639 ns/iter |
1.02 |
E2E_Evaluator_cypress |
172743.4787416819 ns/iter |
173670.61528725713 ns/iter |
0.99 |
E2E_Evaluator_deno |
338875.9405747223 ns/iter |
333085.3077290451 ns/iter |
1.02 |
E2E_Evaluator_dependabot |
469686.15256497863 ns/iter |
468641.9821429133 ns/iter |
1.00 |
E2E_Evaluator_draft_04 |
8692819.530863373 ns/iter |
6528772.313726329 ns/iter |
1.33 |
E2E_Evaluator_fabric_mod |
752862.7157081242 ns/iter |
740619.3382664279 ns/iter |
1.02 |
E2E_Evaluator_geojson |
16893273.83333724 ns/iter |
16163261.720928561 ns/iter |
1.05 |
E2E_Evaluator_gitpod_configuration |
260328.17370542823 ns/iter |
254724.99602315444 ns/iter |
1.02 |
E2E_Evaluator_helm_chart_lock |
318921.7431870543 ns/iter |
322840.3940657899 ns/iter |
0.99 |
E2E_Evaluator_importmap |
49635.430009023585 ns/iter |
49440.23433714589 ns/iter |
1.00 |
E2E_Evaluator_jasmine |
115084.68157334744 ns/iter |
119929.96259644683 ns/iter |
0.96 |
E2E_Evaluator_jshintrc |
1035911.4482250775 ns/iter |
1058170.31070897 ns/iter |
0.98 |
E2E_Evaluator_jsconfig |
413171.92072813434 ns/iter |
416659.9738406034 ns/iter |
0.99 |
E2E_Evaluator_krakend |
210402.8776740156 ns/iter |
209122.62798333087 ns/iter |
1.01 |
E2E_Evaluator_lazygit |
136924.09428795366 ns/iter |
146851.7607426113 ns/iter |
0.93 |
E2E_Evaluator_lerna |
152584.72937739425 ns/iter |
153900.4513525179 ns/iter |
0.99 |
E2E_Evaluator_nest_cli |
199091.27132435466 ns/iter |
200289.1575492389 ns/iter |
0.99 |
E2E_Evaluator_omc |
19316.85428334273 ns/iter |
19503.95689510623 ns/iter |
0.99 |
E2E_Evaluator_omnisharp |
544629.8151657309 ns/iter |
560747.0639489816 ns/iter |
0.97 |
E2E_Evaluator_openapi |
16248556.139538947 ns/iter |
13049089.880000792 ns/iter |
1.25 |
E2E_Evaluator_pre_commit_hooks |
515929.50074284134 ns/iter |
518862.2940298711 ns/iter |
0.99 |
E2E_Evaluator_pulumi |
738562.6133188885 ns/iter |
750224.4693653663 ns/iter |
0.98 |
E2E_Evaluator_semantic_release |
103038.348762249 ns/iter |
107256.96864736159 ns/iter |
0.96 |
E2E_Evaluator_stale |
155147.11121076872 ns/iter |
153635.79442127628 ns/iter |
1.01 |
E2E_Evaluator_stylecop |
318846.7494524349 ns/iter |
306778.1508850074 ns/iter |
1.04 |
E2E_Evaluator_tmuxinator |
102247.27790699717 ns/iter |
101503.32459061703 ns/iter |
1.01 |
E2E_Evaluator_ui5 |
544646.4520440093 ns/iter |
536408.2393821457 ns/iter |
1.02 |
E2E_Evaluator_ui5_manifest |
4162906.091954906 ns/iter |
2743981.502007444 ns/iter |
1.52 |
E2E_Evaluator_unreal_engine_uproject |
467671.637281399 ns/iter |
479578.32763338747 ns/iter |
0.98 |
E2E_Evaluator_vercel |
321681.2390901109 ns/iter |
323820.0813464385 ns/iter |
0.99 |
E2E_Evaluator_yamllint |
10692.873596187514 ns/iter |
10774.466591638398 ns/iter |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com