Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEPENDENCIES
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
vendorpull https://github.com/sourcemeta/vendorpull 1dcbac42809cf87cb5b045106b863e17ad84ba02
core https://github.com/sourcemeta/core 28d02328c467616ecec2bffd37c07930974fedf2
core https://github.com/sourcemeta/core 63f8b0fc592fc78694ae59e0b6cbdf009a65b135
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The dependency pin does not match the commit specified by this PR’s stated upgrade target, so the wrong Core revision is being introduced.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At DEPENDENCIES, line 2:

<comment>The dependency pin does not match the commit specified by this PR’s stated upgrade target, so the wrong Core revision is being introduced.</comment>

<file context>
@@ -1,3 +1,3 @@
 vendorpull https://github.com/sourcemeta/vendorpull 1dcbac42809cf87cb5b045106b863e17ad84ba02
-core https://github.com/sourcemeta/core 2eb445bacd0f0137c01b65c0289aa6ded67b2283
+core https://github.com/sourcemeta/core 63f8b0fc592fc78694ae59e0b6cbdf009a65b135
 jsonschema-test-suite https://github.com/json-schema-org/JSON-Schema-Test-Suite 06481b143722c8c06671bd40dcde99b422ffd531
</file context>
Suggested change
core https://github.com/sourcemeta/core 63f8b0fc592fc78694ae59e0b6cbdf009a65b135
core https://github.com/sourcemeta/core 2eb445bacd0f0137c01b65c0289aa6ded67b2283
Fix with Cubic

jsonschema-test-suite https://github.com/json-schema-org/JSON-Schema-Test-Suite 06481b143722c8c06671bd40dcde99b422ffd531
21 changes: 21 additions & 0 deletions test/evaluator/evaluator_2020_12_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1520,6 +1520,27 @@ TEST(Evaluator_2020_12, dynamicRef_3) {
"in scope that declared the dynamic anchor \"meta\"");
}

TEST(Evaluator_2020_12, ref_with_percent_encoded_colon_in_fragment) {
const sourcemeta::core::JSON schema{sourcemeta::core::parse_json(R"JSON({
"$schema": "https://json-schema.org/draft/2020-12/schema",
"$ref": "#/$defs/https%3A~1~1example.com~1schema~1type",
"$defs": {
"https://example.com/schema/type": { "type": "string" }
}
})JSON")};

const sourcemeta::core::JSON instance{"foo"};
EVALUATE_WITH_TRACE_FAST_SUCCESS(schema, instance, 1, "");

EVALUATE_TRACE_PRE(0, AssertionTypeStrict, "/$ref/type",
"#/$defs/https:~1~1example.com~1schema~1type/type", "");
EVALUATE_TRACE_POST_SUCCESS(
0, AssertionTypeStrict, "/$ref/type",
"#/$defs/https:~1~1example.com~1schema~1type/type", "");
EVALUATE_TRACE_POST_DESCRIBE(instance, 0,
"The value was expected to be of type string");
}

TEST(Evaluator_2020_12, definitions_1) {
const sourcemeta::core::JSON schema{sourcemeta::core::parse_json(R"JSON({
"$schema": "https://json-schema.org/draft/2020-12/schema",
Expand Down
9 changes: 9 additions & 0 deletions vendor/core/CMakeLists.txt

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions vendor/core/config.cmake.in

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 28 additions & 10 deletions vendor/core/src/core/jsonschema/jsonschema.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

44 changes: 43 additions & 1 deletion vendor/core/src/core/uri/canonicalize.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading