short circuit suspension if deleting resource and it is not found#39
Merged
Conversation
sourcehawk
commented
Mar 22, 2026
There was a problem hiding this comment.
Pull request overview
This PR updates the component suspension workflow to avoid create→delete churn for resources configured with DeleteOnSuspend when the object is already absent from the cluster.
Changes:
- Add a short-circuit in
suspendResourceto immediately treat absentDeleteOnSuspendresources asSuspended. - Add tests covering the new short-circuit behavior and error handling for failed existence checks.
- Update suspension lifecycle documentation to describe the new behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
pkg/component/suspend.go |
Adds an existence check/early return for DeleteOnSuspend resources that are already NotFound during suspension. |
pkg/component/suspend_test.go |
Adds new unit tests validating the early-return path and error propagation. |
docs/component.md |
Documents creation-in-suspended-state behavior and the new DeleteOnSuspend “already absent” short-circuit. |
…hawk/operator-component-framework into fix/suspension-logic-shortcircuit
sourcehawk
added a commit
that referenced
this pull request
Mar 23, 2026
* short circuit suspension if deleting resource and it is not found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.