check if the content and the wrapper exists before computing the sizes#123
Open
alexnaiman wants to merge 8 commits intosouhe:masterfrom
Open
check if the content and the wrapper exists before computing the sizes#123alexnaiman wants to merge 8 commits intosouhe:masterfrom
alexnaiman wants to merge 8 commits intosouhe:masterfrom
Conversation
…s of the container avoiding componentDidMount errors when calling scrollToBottom/refresh
…s of the container avoiding componentDidMount errors when calling scrollToBottom/refresh
…efore-computing-sizes' into checking-if-the-content-exists-before-computing-sizes
souhe
requested changes
Jul 5, 2018
Owner
|
@alexnaiman thanks for your work. I left to minor comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had some problems with the functions
scrollToBottomandrefreshcalling them fromcomponentDIdMount()/componentDidUpdate()that showed that the container field of the object was null.I believe that one should verify if the fields are defined and if not to initialise the requested variables with zero (width and height).