CI: verify feat/hmac-env-binding#3
Closed
soufian3hm wants to merge 1 commit into
Closed
Conversation
From the launch security audit (dodopayments#55): the MAC input was only the subscriber id, so isolation rested entirely on per-environment secrets. If two environments ever shared one (manual DB edit, restored dump), a hash would transfer between them. The hash becomes hex(HMAC-SHA256(secret, env_typeid || 0x00 || subscriber_id)), checked against both secret slots so it composes with rotation. The legacy unbound form stays accepted while CHIMELY_SUBSCRIBER_HASH_LEGACY_ACCEPT is true (the default), giving deployed backends a migration window. Docs updated to the bound form. Closes dodopayments#55
Owner
Author
|
CI green first attempt (fmt, clippy, nextest incl. the new redteam_hmac_env_binding suite, license, docker). Upstream: dodopayments#79 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intra-fork draft to run full CI before the upstream PR.