CI: verify fix/log-hygiene#2
Closed
soufian3hm wants to merge 2 commits into
Closed
Conversation
Log-hygiene hardening from the launch audit (dodopayments#58): H4: extractor rejections and the preference channel check answered 400s with prose that quotes caller-supplied scalars. Rejection messages are now static per failure class, with a canary regression test proving no echo. H3: CHIMELY_LOG_SCRUB_IDENTIFIERS (default off) additionally redacts subscriber_id and environment query params and the subscriber path segment from the access log and the http.request span. subscriber_hash stays unconditionally scrubbed. H2: the plain-INSERT conflict interception rule is recorded at the generic error-logging site. Closes dodopayments#58
Owner
Author
|
CI green after the chaos.rs Config literal fix. Upstream: dodopayments#77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intra-fork draft to run full CI before the upstream PR. Blocked on the account billing unlock; will be closed once green.