Conversation
javierggt
reviewed
Mar 11, 2026
Contributor
javierggt
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
I created a package using the command documented in the skare3 wiki:
from skare3_tools.github import Repository
repo = Repository("sot/skare3")
repo.dispatch_event(
event_type='build-package',
client_payload={
"package": "arc",
"tag": "package",
"arch": True,
"upload": True,
"skare3_branch": "replan_central",
}
)
The resulting package fails to install on OSX because the package depends on packages that are only for linux (perl-extended-deps, perl-ska-convert). Was that intended?
I installed it on a test environment on HEAD and that worked. I then just checked that the entrypoints were there. No further functional check.
Contributor
Author
|
Yeah, I figured it was safer to only let this install on linux, but if that causes more problems for management, I can cut the dependencies in the recipe. Either way. |
Contributor
|
It does not cause any problem for management |
javierggt
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a recipe to build replan central.
This works with the build in the "package" branch in sot/arc#96 .
Tested against ac4c84b using ska_builder.py on Linux only.