Open
Conversation
5 tasks
jeanconn
reviewed
Mar 17, 2026
jeanconn
reviewed
Mar 17, 2026
2 tasks
…andling and simplify temperature configuration
There is no strong driver for this as config
Member
Author
|
@jeanconn - I have completed all TODOs and planned work for this PR so it is ready for final review. |
Contributor
|
It looked to me like the proseco tests are failing again which I didn't completely understand in the context of the chandra_aca changes since they last passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a major update to the ACA pixel row,col <=> angle yag,zag transformations.
This includes:
pixels_to_yagzaguse the 2020 calibration coefficents by default.yagzag_to_pixelsuse Newton's method to accurately invertpixels_to_yagzagusing a good starting point.This PR uses numba-accelerated routines to improve performance and accuracy.
TODO:
Fixes #152
Interface impacts
t_aca=35.0(from previous 20.0) is likely going to cause regressions (albeit benign) in places. This will change some answers but for the better in the modern era.allow_badchange to True could result in not raising an exception. Likely not impacting.Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.