Update paths for MTA radiation reorg#95
Merged
jeanconn merged 7 commits intokadi-scenariofrom Sep 26, 2025
Merged
Conversation
taldcroft
approved these changes
Sep 26, 2025
Member
There was a problem hiding this comment.
LGTM for code.
Of note to put in the description:
- Two
mta_*_imgconfig definitions removed since they were unused. - Interface impact (upstream) that the ACE plot has changed to light mode (or maybe just colors reversed). I'm not sure this has been widely noted, but for a plot that everyone has been looking at for 25 years it should be mentioned.
Member
|
Also, you should document your process for finding paths that need to be updated. I see that all the diffs look reasonable but it's hard to know if this is complete. |
Contributor
Author
|
I've flushed out the Description though I had planned to link to the MTA google doc in the FSDS. |
Member
|
Thanks looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update paths for MTA radiation reorganization.
With regard to process, I reviewed the MTA doc noting path reorganization, focused mostly on summary, GOES, and ACE products, and manually reviewed the configuration data for replan central to update these paths. The supported / new paths work now. The intent is that this PR proactively updates the page so content will still work when the now-deprecated MTA pages are eventually removed - if anything has been missed in the replan central review and becomes apparent when the upstream resources are no longer available, we'll update any missed paths in a future PR.
I also removed references to two images provided by MTA in the config, as they were no longer used.
Interface impacts
The ACE plot displayed on the Replan Central page will now have a white instead of black background, as the upstream page from MTA is now only available in that scheme.
Functional testing
I put an on-the side job up at
https://cxc.cfa.harvard.edu/mta/ASPECT/arc3-pr95/