Conversation
…(do not use repr)
18 tasks
jeanconn
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses issues encountered after upgrading numpy to version 2:
np.in1dis deprecatedA quick comment: numpy 2 is correct, because the ideal repr() implementation should return a string that, when passed to eval(), would reconstruct an object equal to the original.
In python 3.12 and numpy 1.26.4:
in python 3.13 and numpy 2.3.5
This causes issues in agasc tests, because some values are passed to a command line using a format like
this causes the format to be applied on
repr(agasc_id)which now will be'np.int32(1)'Interface impacts
Testing
Unit tests
Independent check of unit tests by Jean
Functional tests
No functional testing.