Get last_updated supplement table without error

[javierggt]

Description

This PR fixes an exception that happens when one does agasc.get_supplement_table("last_updated") without specifying as_dict=True. Specifying as_dict=True is not intuitive and not expected, and anyway last_updated and agasc_versions are always better as dicts.

Interface impacts

Testing

Unit tests

Added a unit test for this and checked that it fails on master as expected.

• No unit tests
• Mac
• Linux
• Windows

# note that this is run on the commit before the ruff commit, which just adds whitespace
(ska3-flight) ~/SAO/git/agasc last_updated $ git rev-parse HEAD                                                     
fc21dc784584a757adbcd5e6e44ab678eba35dc8
(ska3-flight) ~/SAO/git/agasc last_updated $ pytest agasc
==================================================================== test session starts =====================================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/javierg/SAO/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 79 items                                                                                                                                           

agasc/tests/test_agasc_1.py .......                                                                                                                    [  8%]
agasc/tests/test_agasc_2.py ..........sssss..........ss....................                                                                            [ 68%]
agasc/tests/test_agasc_healpix.py .ssssssssss                                                                                                          [ 82%]
agasc/tests/test_obs_status.py ..............                                                                                                          [100%]

=============================================================== 62 passed, 17 skipped in 5.71s ===============================================================

Independent check of unit tests by [REVIEWER NAME]

• [PLATFORM]:

Functional tests

You can quickly check this by running the following code. It should fail on master and succeed the branch:

import agasc
agasc.get_supplement_table("last_updated")

and

import agasc
agasc.get_supplement_table("agasc_versions")

[taldcroft]

Looks good. Please always document your testing with the git rev-parse HEAD output and a copy/paste of the pytest results along with any custom setup. It's a slight hassle but otherwise there is no record of which version was tested.

[taldcroft]

I see that there is no other testing of these supplement tables. So while you are at it, it would be worth testing:

• last_updated has the correct four keys
• Each corresponding value is a string that is a valid ISO format date CxoTime(last_updated[key], format="iso").
• agasc_versions has the same four keys.

The name of the test function does not quite match what it does.

[javierggt]

I think I addressed this comment in my last commit.

[taldcroft]

@javierggt - is this PR overtaken by #203 or events?

[javierggt]

@javierggt - is this PR overtaken by #203 or events?

No. It's still valid. I added some text to the functional test description so you can check.

My guess is that this PR stalled after you asked for further changes. I made those changes now, so this should be good.

[taldcroft]

LGTM