[WIP] Allow more general knot sequences#5
Draft
sostock wants to merge 26 commits into
Draft
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 95.20% 95.50% +0.29%
==========================================
Files 6 6
Lines 501 534 +33
==========================================
+ Hits 477 510 +33
Misses 24 24
Continue to review full report at Codecov.
|
Repository owner
deleted a comment from
codecov-commenter
Feb 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to implement support for knot sequences where the first and last breakpoints appear less than
order(basis)times. It is currently work in progress, and at a very early stage.BSplineBasisBSplineBasis(k, knots=...)andBSplineBasis(k, breakpoints=...). Deprecate the old (non-keyword) constructor.BSplineBasiswith aUnitRangeto create a newBSplineBasis. Supportviewas well.bsplines/bsplines!return anOffsetArrayof aview.bsplines/bsplines!/splinevalueto work with the new knot vectors.indiceskeyword argument, recommend to useview(::BSplineBasis, ...)instead.