Repository navigation
feat: support PHP 8.3 and 8.4, PHPUnit 12 and Pest 4 - #1
Merged
Merged
Conversation
The package now installs next to PHPUnit 12.5, Pest 4, Laravel 12 and Symfony 7.4. Two lines use syntax of PHP 8.4 and 8.5 no more. The Symfony polyfills supply the newer array and mb functions. The CI tests PHP 8.3, 8.4 and 8.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Projects on Laravel 12 cannot install the package. Version 1.0.0 needs PHP 8.5 and PHPUnit 13, and Laravel 12 has neither PHPUnit 13 nor Pest 5.
What changes
phpis^8.3,phpunit/phpunitis^12.5|^13.2.symfony/polyfill-php84andsymfony/polyfill-php85supplyarray_find,array_any,mb_trim,array_firstandarray_lastbelow PHP 8.5.Html::text()usesmb_trim()in place of the pipe operator.AppearsBeforeputsnew DOMXPath(...)in parentheses again.CI
The CI tests three stacks:
composer.lock--prefer-lowestis not used. The lowest patch releases of Pest 4.7 andmasterminds/html5give PHPStan errors and PHP deprecations that do not come from this package.Release
After the merge: tag
v1.1.0.