Repository navigation
test(e2e): retry entering a container until it opens - #158
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.19.0 release run failed here and the tag was rejected. Dispatching the same Linux job on the same commit passed, so it is a flake rather than a break - but a flake in a release gate blocks releases, so it is worth removing rather than re-rolling.
The helper double-clicked a row once and then waited for a child to appear. Two mouse clicks only register as a double-click if they land close enough together in time, which a loaded runner does not guarantee: the clicks are read as two separate ones, the container never opens, and the wait times out on a child that was never going to show.
Entering a container now retries the double-click until a child appears, up to four attempts, then makes a final wait so a real failure still reports as one rather than as an exhausted loop. Both call sites use it, and the separate waitFor/dblclick pairs they had collapse into it.
2 tests locally and the full 30-test pack pass.