Repository navigation
Send an empty transport file type when none is known - #191
Merged
Merged
Conversation
A PATCH that changes transport_file.data always includes type. Empty or non-string data is null, and type is null with it. Otherwise type is the staged string, or "" when that value is not a string. Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
Signed-off-by: Gareth Sylvester-Bradley <garethsb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rethought 8b725a7. nmos-js should not knowingly send something that is not valid per the schema, so an empty string is a better fallback than omitting type. The default for a known transport is
TRANSPORTS.<transportUrnBase>.transportFileType;makeConnectionand the receiver staged editor read it withtransportFileType.