Conversation
|
Important Review skippedToo many files! This PR contains 243 files, which is 93 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (243)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @sonra44, your pull request is larger than the review limit of 150000 diff characters
Owner
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c89668c8f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+565
to
+568
| kind = str(payload.get("kind") or "").strip().lower() | ||
| command_name = str(((payload.get("payload") or {}).get("command_name"))).strip().lower() | ||
| status = str(((payload.get("payload") or {}).get("status"))).strip().lower() | ||
| if expected in {kind, command_name, status}: |
There was a problem hiding this comment.
_wait_for_ack accepts any previously seen successful ACK whose kind, payload.command_name, or payload.status matches expected, so a stale ACK from an earlier run can satisfy a later step immediately and incorrectly mark a procedure as successful even when the newly published command was never acknowledged; constrain matching to ACKs received after dispatch (or by correlation ID) to avoid false positives.
Useful? React with 👍 / 👎.
Comment on lines
+406
to
+408
| "stream": "EVENTS_REPLAY", | ||
| "timestamp": datetime.now().isoformat(), | ||
| "subject": getattr(msg, "subject", None), |
There was a problem hiding this comment.
Replay history assigns each fetched message timestamp = datetime.now(), so when an event payload does not carry its own timestamp, downstream window filters treat old events as fresh and replay on <seconds> can show out-of-window incidents; use the message metadata timestamp from JetStream instead of the fetch time.
Useful? React with 👍 / 👎.
|
|
||
| def _show_help(self) -> None: | ||
| self._set_help_text( | ||
| "Levels f1/f2/f3/f4/f6/f7 | Incidents up/down ack clear select <id> | " |
There was a problem hiding this comment.
/workspace/QIKI_DTMP/AGENTS.md requires operator-console UI strings to be bilingual EN/RU (without spaces around /), but this newly introduced help text is English-only; this violates the documented console contract and leaves RU operators without the required localized command guidance.
Useful? React with 👍 / 👎.
Reinitialize the branch history from the current working base so the remote branch matches the local repository snapshot. Ignored files remain excluded by normal git policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 7 is completed on branch
ORIONand locks ORION V as the default operator console runtime.Included in this PR
Stage 7 Artifacts
TASKS/TASK_stage7_primary_switch.mdTASKS/TASK_stage7_final_cutover.mddocs/RELEASE_NOTES_ORIONV_1.0.0.mddocs/CUTOVER_PLAN.mddocs/ORION_V_RUNBOOK.mddocs/ORION_V_QUICKSTART.mdValidation Snapshot
orionv-1.0.0