Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new crate
ffi-convert-extra-ctypesto the workspace an moves theCArray,CStringArray, andCRangetypes to it.The rationale is that these types are optional and and don't need to pollute the API of the base crate.
Having them is a separate crate also makes it cleaner when asking
cbindgento parse specific dependencies. Now it only has to parse stuff that will actually be useful to it and not the wholeffi-convertcrate (only those type will endup in a C header, they should by the way probably be renamed in the cbindgen config if you are using them)