feat: enhanced array conversion and drop#59
Merged
fredszaq merged 1 commit intosonos:mainfrom Apr 15, 2026
Merged
Conversation
fredszaq
added a commit
that referenced
this pull request
Apr 15, 2026
Collaborator
|
Thanks a lot @carlocorradini ! This is waaaay better than what we had before ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CReprOfandAsRustfor arrays have been improved by eliminating the temporary vector using an array ofMaybeUninitalong with additional logic to prevent memory leaks.CReprOfexplicitly callsCDrop::do_dropon initialized items if an error occurs.AsRustcallsMaybeUninit::assume_init_dropon initialized items if an error occurs.CDropcallsCDrop::do_dropon each element in the array, returning the first error encountered, if any.PS: The code is inspired and adapted from sharksforarms/deku/src/impls/slice.rs, for which I’ve submitted PR sharksforarms/deku#601