Skip to content

Added missing ccmis vdm observables #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkanchi-nexthop wants to merge 1 commit into
base: master
Choose a base branch
from
+34 −3
Open

Added missing ccmis vdm observables #706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion sonic_platform_base/sonic_xcvr/api/public/c_cmis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@
'CFO [MHz]' : 'cfo',
'Tx Power [dBm]' : 'txcurrpower',
'Rx Total Power [dBm]' : 'rxtotpower',
'Rx Signal Power [dBm]' : 'rxsigpower'
'Rx Signal Power [dBm]' : 'rxsigpower',
'Clock Recovery Loop [%]' : 'clkreloop',
'SOPMD low granularity [ps^2]' : 'sopmdshort',
'SNR Margin [dB]' : 'snrmargin',
'Q-Factor [dB]' : 'qfactor',
'Q-Margin [dB]' : 'qmargin',
'CFO low granularity [MHz]' : 'cfoshort'
}

VDM_SUBTYPE_IDX_MAP= {
Expand Down
21 changes: 20 additions & 1 deletion sonic_platform_base/sonic_xcvr/api/public/cmis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2037,6 +2037,12 @@ def get_transceiver_vdm_real_value_basic(self):
txcurrpower{lane_num} = FLOAT ; tx current output power in dbm
rxtotpower{lane_num} = FLOAT ; rx total power in dbm
rxsigpower{lane_num} = FLOAT ; rx signal power in dbm
clkreloop{lane_num} = FLOAT ; clock recovery loop in percentage
sopmdshort{lane_num} = FLOAT ; second order polarization mode dispersion, low granularity in ps^2
snrmargin{lane_num} = FLOAT ; snr margin in db
qfactor{lane_num} = FLOAT ; q-factor in db
qmargin{lane_num} = FLOAT ; q-margin in db
cfoshort{lane_num} = FLOAT ; carrier frequency offset, low granularity in MHz
========================================================================
"""
vdm_real_value_dict = dict()
Expand Down Expand Up @@ -2131,7 +2137,14 @@ def get_transceiver_vdm_thresholds(self):
cfo_xxx{lane_num} = FLOAT ; carrier frequency offset in Hz (high/low alarm/warning)
txcurrpower_xxx{lane_num} = FLOAT ; tx current output power in dbm (high/low alarm/warning)
rxtotpower_xxx{lane_num} = FLOAT ; rx total power in dbm (high/low alarm/warning)
rxsigpower_xxx{lane_num} = FLOAT ; rx signal power in dbm (high/low alarm/warning) ========================================================================
rxsigpower_xxx{lane_num} = FLOAT ; rx signal power in dbm (high/low alarm/warning)
clkreloop_xxx{lane_num} = FLOAT ; clock recovery loop in percentage (high/low alarm/warning)
sopmdshort_xxx{lane_num} = FLOAT ; second order polarization mode dispersion, low granularity in ps^2 (high/low alarm/warning)
snrmargin_xxx{lane_num} = FLOAT ; snr margin in db (high/low alarm/warning)
qfactor_xxx{lane_num} = FLOAT ; q-factor in db (high/low alarm/warning)
qmargin_xxx{lane_num} = FLOAT ; q-margin in db (high/low alarm/warning)
cfoshort_xxx{lane_num} = FLOAT ; carrier frequency offset, low granularity in MHz (high/low alarm/warning)
========================================================================
"""
vdm_thresholds_dict = dict()
vdm_raw_dict = self.get_vdm(self.vdm.VDM_THRESHOLD, self.vdm.VDM_OBSERVABLE_ALL)
Expand Down Expand Up @@ -2199,6 +2212,12 @@ def get_transceiver_vdm_flags(self):
txcurrpower_xxx{lane_num} = FLOAT ; tx current output power in dbm (high/low alarm/warning flag)
rxtotpower_xxx{lane_num} = FLOAT ; rx total power in dbm (high/low alarm/warning flag)
rxsigpower_xxx{lane_num} = FLOAT ; rx signal power in dbm (high/low alarm/warning flag)
clkreloop_xxx{lane_num} = FLOAT ; clock recovery loop in percentage (high/low alarm/warning flag)
sopmdshort_xxx{lane_num} = FLOAT ; second order polarization mode dispersion, low granularity in ps^2 (high/low alarm/warning flag)
snrmargin_xxx{lane_num} = FLOAT ; snr margin in db (high/low alarm/warning flag)
qfactor_xxx{lane_num} = FLOAT ; q-factor in db (high/low alarm/warning flag)
qmargin_xxx{lane_num} = FLOAT ; q-margin in db (high/low alarm/warning flag)
cfoshort_xxx{lane_num} = FLOAT ; carrier frequency offset, low granularity in MHz (high/low alarm/warning flag)
"""
vdm_flags_dict = dict()
vdm_raw_dict = self.get_vdm(self.vdm.VDM_FLAG, self.vdm.VDM_OBSERVABLE_ALL)
Expand Down
8 changes: 7 additions & 1 deletion sonic_platform_base/sonic_xcvr/codes/public/cmis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,13 @@ class CmisCodes(Sff8024):
144: ['Rx Total Power [dBm]', 'S16', 0.01, 'B'],
145: ['Rx Signal Power [dBm]', 'S16', 0.01, 'B'],
146: ['SOP ROC [krad/s]', 'U16', 1, 'B'],
147: ['MER [dB]', 'U16', 0.1, 'B']
147: ['MER [dB]', 'U16', 0.1, 'B'],
148: ['Clock Recovery Loop [%]', 'S16', 100.0/32767, 'B'],
149: ['SOPMD low granularity [ps^2]', 'U16', 1, 'B'],
150: ['SNR Margin [dB]', 'S16', 0.1, 'B'],
151: ['Q-Factor [dB]', 'U16', 0.1, 'B'],
152: ['Q-Margin [dB]', 'S16', 0.1, 'B'],
153: ['CFO low granularity [MHz]', 'S16', 5, 'B']
}

CDB_FAIL_STATUS = {
Expand Down
Loading