Skip to content

[ModuleBase] Add get_midplane_down_reason() API and MIDPLANE_DOWN_REASON_* constants#705

Open
chartsai-nvidia wants to merge 1 commit into
sonic-net:masterfrom
chartsai-nvidia:chartsai/pmon-hld-update
Open

[ModuleBase] Add get_midplane_down_reason() API and MIDPLANE_DOWN_REASON_* constants#705
chartsai-nvidia wants to merge 1 commit into
sonic-net:masterfrom
chartsai-nvidia:chartsai/pmon-hld-update

Conversation

@chartsai-nvidia

Copy link
Copy Markdown

Why I did it

Modular chassis / SmartSwitch platforms need a standard way to report why a module's midplane
went down. ModuleBase exposes reachability but no reason. Part of the DPU robustness HLD.

Work item tracking
  • Microsoft ADO (number only): N/A

How I did it

  • Added MIDPLANE_DOWN_REASON_* constants to ModuleBase (aligned with chassis reboot causes).
  • Added get_midplane_down_reason() returning a (reason, description) tuple, default
    raise NotImplementedError.
  • Covered the new method in test_not_implemented_methods_raise.

How to verify it

cd src/sonic-platform-common && pytest tests/module_base_test.py

Signed-off-by: Charles Tsai <chartsai@nvidia.com>
@mssonicbld

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi, there are workflow run(s) waiting for approval, you may be first-time contributor. I will notify maintainers to help approve once PR is approved. Thanks!

---Powered by SONiC BuildBot

@mssonicbld

Copy link
Copy Markdown
Collaborator

Hi @sonic-net/sonic-platform-common-maintainer, this approved PR has workflow run(s) waiting for approval. Please help review. Thanks!

---Powered by SONiC BuildBot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants