Skip to content

Add parameterized tests for get_manufacturer and get_model #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenyiz2021 merged 1 commit into from
Jul 2, 2026
+11 −0
Merged

Add parameterized tests for get_manufacturer and get_model #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tests/sonic_xcvr/test_cmis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,17 @@ def setup_method(self, method):
self.api._cdb_fw_hdlr = None
self.api._init_cdb_fw_handler = False

@pytest.mark.parametrize("mock_response, expected", [
("VENDOR_NAME", "VENDOR_NAME"),
("A\x00\x00\x00\x00\x00Networks\n", "ANetworks"),
])
def test_get_manufacturer(self, mock_response, expected):
self.api.xcvr_eeprom.read = MagicMock()
self.api.xcvr_eeprom.read.return_value = mock_response
self.clear_cache('get_manufacturer')
result = self.api.get_manufacturer()
assert result == expected

@pytest.mark.parametrize("mock_response, expected", [
("1234567890", "1234567890"),
("ABCD", "ABCD")
Expand Down
Loading