Revert "Fix UnicodeDecodeError in xcvr API for corrupted EEPROM (#633)"#661
Merged
Merged
Conversation
…c-net#633)" This reverts commit 2fbd4f8. Signed-off-by: arpit-nexthop <arpit@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
previously approved these changes
May 6, 2026
…ode_decode # Conflicts: # sonic_platform_base/sonic_xcvr/xcvr_api_factory.py
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
The revert of sonic-net#633 restores strict .decode() in get_vendor_name(), so undecodable EEPROM bytes correctly raise UnicodeDecodeError again. Remove the test that asserted the old error-tolerant behavior. Signed-off-by: arpit-nexthop <arpit@nexthop.ai>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Do not ignore errors for corrupted EEPROM
Motivation and Context
If we have a corrupt EEPROM, SI settings notification may fail since we rely on these for parsing SI. Reverting the original commit that allowed this.
How Has This Been Tested?
Additional Information (Optional)