Fix the Broadcom supported cmds list in techsupport#24770
Merged
StormLiangMS merged 1 commit intoMay 28, 2026
Merged
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Due to the changes in sonic-net/sonic-utilities#4542, the show_techsupport test needs to check Broadcom commands based on the chip module. The fix separates non-TH5 and TH5 commands into different lists and combines with the common ones before checking. Signed-off-by: yaopingzhu <yaopingzhu@arista.com>
yaopingz
force-pushed
the
pr-fix-bcm-supported-cmds-in-techsupport
branch
from
f89e515 to
61cea30
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mssonicbld
added
the
Request for 202511 branch
Collaborator
|
This PR has backport request for branch(es): 202511. ---Powered by SONiC BuildBot
|
davidm-arista
approved these changes
May 27, 2026
lakshmi-nexthop
approved these changes
May 27, 2026
| 'bcmcmd{} "d chg my_station_tcam"', | ||
| ] | ||
|
|
||
| broadcom_cmd_bcmcmd_xgs_th5 = [ |
There was a problem hiding this comment.
is this for all Lt chips? should we rename this to broadcom_cmd_bcmcmd_xgs_lt to avoid updating this for th6/7 etc?
Contributor
Author
There was a problem hiding this comment.
renaming is fine if the same commands applied for th6/7.
better to double check with broadcom and verify before change. @purush-nexthop
Collaborator
|
LGTM. could you check comment from @purush-nexthop as a follow up? @yaopingz |
StormLiangMS
approved these changes
May 28, 2026
Open
12 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#1213 |
Collaborator
|
Cherry-pick PR to 202511: #24911 |
12 tasks
Collaborator
|
@yaopingz cherry pick PR didn't pass PR checker after retry. Please help check! Thanks. ---Powered by SONiC BuildBot
|
DeekshaBhandary
pushed a commit
to DeekshaBhandary/sonic-mgmt
that referenced
this pull request
Jun 4, 2026
Due to the changes in [PR#4542](sonic-net/sonic-utilities#4542), the show_techsupport test needs to check Broadcom commands based on the chip module. The fix separates non-TH5 and TH5 commands into different lists (broadcom_cmd_bcmcmd_xgs_soc and broadcom_cmd_bcmcmd_xgs_th5) and combines with the common commands list (broadcom_cmd_bcmcmd_xgs) before checking. <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 - [ ] 202512 - [ ] 202605 ### Approach #### What is the motivation for this PR? To address show_techsupport test failure after [PR#4542](sonic-net/sonic-utilities#4542) is merged. #### How did you do it? #### How did you verify/test it? Run show_techsupport test on the DUTs with Broadcom non-TH5 and TH5 chipsets, and verify no failed cases. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: yaopingzhu <yaopingzhu@arista.com> Signed-off-by: DeekshaBhandary <deekshabhandary1@gmail.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jun 11, 2026
Due to the changes in [PR#4542](sonic-net/sonic-utilities#4542), the show_techsupport test needs to check Broadcom commands based on the chip module. The fix separates non-TH5 and TH5 commands into different lists (broadcom_cmd_bcmcmd_xgs_soc and broadcom_cmd_bcmcmd_xgs_th5) and combines with the common commands list (broadcom_cmd_bcmcmd_xgs) before checking. <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 - [ ] 202512 - [ ] 202605 ### Approach #### What is the motivation for this PR? To address show_techsupport test failure after [PR#4542](sonic-net/sonic-utilities#4542) is merged. #### How did you do it? #### How did you verify/test it? Run show_techsupport test on the DUTs with Broadcom non-TH5 and TH5 chipsets, and verify no failed cases. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: yaopingzhu <yaopingzhu@arista.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Jun 25, 2026
Due to the changes in [PR#4542](sonic-net/sonic-utilities#4542), the show_techsupport test needs to check Broadcom commands based on the chip module. The fix separates non-TH5 and TH5 commands into different lists (broadcom_cmd_bcmcmd_xgs_soc and broadcom_cmd_bcmcmd_xgs_th5) and combines with the common commands list (broadcom_cmd_bcmcmd_xgs) before checking. <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 - [ ] 202512 - [ ] 202605 ### Approach #### What is the motivation for this PR? To address show_techsupport test failure after [PR#4542](sonic-net/sonic-utilities#4542) is merged. #### How did you do it? #### How did you verify/test it? Run show_techsupport test on the DUTs with Broadcom non-TH5 and TH5 chipsets, and verify no failed cases. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> Signed-off-by: yaopingzhu <yaopingzhu@arista.com> Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the changes in PR#4542, the show_techsupport test needs to check Broadcom commands based on the chip module.
The fix separates non-TH5 and TH5 commands into different lists (broadcom_cmd_bcmcmd_xgs_soc and broadcom_cmd_bcmcmd_xgs_th5) and combines with the common commands list (broadcom_cmd_bcmcmd_xgs) before checking.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
To address show_techsupport test failure after PR#4542 is merged.
How did you do it?
How did you verify/test it?
Run show_techsupport test on the DUTs with Broadcom non-TH5 and TH5 chipsets, and verify no failed cases.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation