Adjust test_dynamic_acl.py so it can handle only ipv6 topologies.#20608
Merged
Conversation
example
1. adding reeboot before running the test to clean up the db for reset the faults counters 2. adding command that bringup all the ports od the device 3. addding condition for the picked ports, that they are up and connected to optical module.
remove Nvidia platform checks
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
roy-sror
approved these changes
Oct 28, 2025
albertovillarreal-keys
pushed a commit
to albertovillarreal-keys/sonic-mgmt
that referenced
this pull request
Dec 2, 2025
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies. Signed-off-by: Alberto Villarreal <alberto.villarreal@keysight.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Dec 11, 2025
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies. Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-mgmt
that referenced
this pull request
Dec 15, 2025
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies. Signed-off-by: Saravanan <saravanan@nexthop.ai>
| - "'t0-isolated' in topo_name" | ||
|
|
||
| generic_config_updater/test_dynamic_acl.py::test_gcu_acl_forward_rule_removal: | ||
| xfail: |
Contributor
There was a problem hiding this comment.
Should't skip be used here instead?
gshemesh2
added a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Collaborator
|
Static analysis is failing on 202412: Azure/sonic-mgmt.msft#924. |
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies.
gshemesh2
added a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Jan 29, 2026
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies.
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies. Signed-off-by: Yael Tzur <ytzur@nvidia.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Apr 20, 2026
…nic-net#20608) Adjust test_dynamic_acl.py so it can handle only ipv6 topologies. Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Adjust test_dynamic_acl.py so it can handle only ipv6 topologies.
How did you do it?
On generate packets method is will create ipv4 packets only if its not
ipv6 topology
test_gcu_acl_forward_rule_removal ,added skip in conditional mark file.
on test_gcu_acl_arp_rule_creation , only if the variable is_ipv4_test is false/raise exception while generate the value (can happen on only
ipv6 topologies) and its running on ipv6 only topology it will be skipped
How did you verify/test it?
ran the test multiple times on ipv6 only topologies
Any platform specific information?
Supported testbed topology if it's a new test case?
ipv6 only topologies
Documentation