Mux recovery when link up comes before ICMP session Active with ICMP Offload#348
Open
harjotsinghpawra wants to merge 1 commit into
Open
Mux recovery when link up comes before ICMP session Active with ICMP Offload#348harjotsinghpawra wants to merge 1 commit into
harjotsinghpawra wants to merge 1 commit into
Conversation
…offload Signed-off-by: Harjot Singh <harjotpawrawork@gmail.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@zjswhhh Please review it if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Solving the bug where is icmp hwoffload reports icmp session up before Link Up . When prober goes active first and MUX is Unknown state then Prober is in Wait but mux gets stuck and Mux never recovers, even after Link comes back up.
The transition handler for (Active, Unknown, Up) is LinkProberActiveMuxUnknownLinkUpTransitionFunction. Because ps(mCompositeState) is already Active when the link-up arrives, it takes the else branch and calls startMuxProbeTimer(), which:
(P: Active, M: Unknown, L: Down)→ link up →(P: Wait, M: Unknown, L: Up)— stuck, no recovery(P: Active, M: Unknown, L: Down)→ link up →(P: Active, M: Unknown, L: Up)→ xcvrd probe →(P: Active, M: Active, L: Up)— recoveredinitLinkProberState()runs as before — no changeinitLinkProberState()runs as before — no changeinitLinkProberState()resets prober unnecessarily(Active, Active, Up)— no redundantswitchMuxStateissuedIssue raised:
sonic-net/sonic-buildimage#26547
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
sonic-net/sonic-buildimage#26547
Bug reported
Work item tracking
How did you do it?
Forced it to do get grpc probe for MUX state if link goes from Up from down and prober is in active
then it will do state transition and MUX will resolve itself using grpc.
How did you verify/test it?
Unit test included in patch
Any platform specific information?
Documentation