Skip to content

Add support for gNOI File Remove#387

Closed
jkmar wants to merge 1 commit into
sonic-net:masterfrom
jkmar:gnoi_file_remove
Closed

Add support for gNOI File Remove#387
jkmar wants to merge 1 commit into
sonic-net:masterfrom
jkmar:gnoi_file_remove

Conversation

@jkmar

@jkmar jkmar commented May 2, 2025

Copy link
Copy Markdown

Why I did it

Add support for gNOI File Remove

How I did it

Implement support for gNOI File Remove using the translib from sonic-mgmt-common.
Other PRs:

How to verify it

Tested on a physical switch:

cisco@sonic:~$ touch /tmp/test_remove
cisco@sonic:~$ docker exec -it gnmi gnoi_client -notls -insecure -module File -rpc Remove -jsonin '{"remote_file":"/tmp/test_remove"}'
File Remove
{}
cisco@sonic:~$ ls -l /tmp/test_remove
ls: cannot access '/tmp/test_remove': No such file or directory
cisco@sonic:~$ docker exec -it gnmi gnoi_client -notls -insecure -module File -rpc Remove -jsonin '{"remote_file":"/tmp/test_remove"}'
File Remove
panic: rpc error: code = Unknown desc = [Errno 2] No such file or directory: dbus.String('/tmp/test_remove')

goroutine 1 [running]:
github.com/sonic-net/sonic-gnmi/gnoi_client/file.Remove(0xc000226c08, {0xbc6eb0, 0xc0001aac30})
        /sonic/src/sonic-gnmi/gnoi_client/file/file.go:45 +0x1a5
main.main()
        /sonic/src/sonic-gnmi/gnoi_client/gnoi_client.go:54 +0x245

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkmar jkmar force-pushed the gnoi_file_remove branch from d550fde to 725e849 Compare May 2, 2025 12:19
@mssonicbld

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkmar jkmar force-pushed the gnoi_file_remove branch from 725e849 to e3cc890 Compare May 2, 2025 13:53
@mssonicbld

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkmar jkmar marked this pull request as ready for review May 2, 2025 15:12
@jkmar

jkmar commented May 14, 2025

Copy link
Copy Markdown
Author

@jkmar jkmar closed this May 16, 2025
@jkmar

jkmar commented May 16, 2025

Copy link
Copy Markdown
Author

Already done by #385

@jkmar jkmar deleted the gnoi_file_remove branch May 16, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants