Skip to content

fix(i18n): arrow notation for the analytics token scope - #391

Merged
sparkyfen merged 1 commit into
mainfrom
claude/sona-200-analytics-scope-notation
Aug 20, 2026
Merged

sparkyfen merged 1 commit into
mainfrom
claude/sona-200-analytics-scope-notation

Conversation

@sparkyfen

@sparkyfen sparkyfen commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

The Connect Cloudflare Analytics dialog named its one permission as Zone · Analytics · Read, while the setup CLIs now write every scope the way the Cloudflare token editor does. The scope chip and the security callout in both locales now read Zone → Analytics: Read — the label itself stays in dashboard English inside the Japanese copy, since it names a Cloudflare UI control. The scope-contract test (cf-analytics-scope.test.ts) pins the new form, and the doc comment in app.d.ts follows.

Mock approved in the Sona design project (screens/admin/connect-cloudflare.html); the same revision fixed the mock's stale Account-level scope. Tracked on SONA-200.

Follows the notation convention established in #390.

Summary by CodeRabbit

  • Documentation
    • Clarified Cloudflare Analytics permission requirements using the consistent Zone → Analytics: Read notation.
    • Updated English and Japanese setup guidance and security callouts.
  • Tests
    • Updated permission-related checks to reflect the revised wording.

The Connect Cloudflare Analytics dialog named its one permission as
'Zone · Analytics · Read' while the setup CLIs now write every scope in
the dashboard's own arrow form. The scope chip and the callout in both
locales now read 'Zone → Analytics: Read' (the label itself stays in
dashboard English inside the Japanese copy), and the scope-contract test
pins the new form. Mock approved in the design project
(screens/admin/connect-cloudflare.html).
@linear-code

linear-code Bot commented Aug 19, 2026

Copy link
Copy Markdown

SONA-200

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 253745d1-dbd7-4cd5-8696-9f52366e76a0

📥 Commits

Reviewing files that changed from the base of the PR and between a1f6b17 and b343157.

📒 Files selected for processing (4)
  • messages/en.json
  • messages/ja.json
  • src/app.d.ts
  • src/lib/server/cf-analytics-scope.test.ts

Disabled knowledge base sources:

  • Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

The change standardizes Cloudflare Analytics permission wording to Zone → Analytics: Read across English and Japanese setup messages, application documentation, and localization tests.

Changes

Cloudflare permission wording

Layer / File(s) Summary
Permission wording and validation
messages/en.json, messages/ja.json, src/app.d.ts, src/lib/server/cf-analytics-scope.test.ts
Updated setup guidance and token documentation to use Zone → Analytics: Read. Updated English and Japanese localization assertions to require the revised wording.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • sona-fast/sona#390: Updates related Cloudflare permission-scope wording to arrow notation in setup messages and tests.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating the analytics token scope to use arrow notation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/sona-200-analytics-scope-notation

Comment @coderabbitai help to get the list of available commands.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

@sparkyfen

Copy link
Copy Markdown
Contributor Author

@coderabbitai summary

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
✅ Action performed

Summary regeneration triggered.

@sparkyfen
sparkyfen merged commit f238568 into main Aug 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant