fix(i18n): arrow notation for the analytics token scope - #391
Conversation
The Connect Cloudflare Analytics dialog named its one permission as 'Zone · Analytics · Read' while the setup CLIs now write every scope in the dashboard's own arrow form. The scope chip and the callout in both locales now read 'Zone → Analytics: Read' (the label itself stays in dashboard English inside the Japanese copy), and the scope-contract test pins the new form. Mock approved in the design project (screens/admin/connect-cloudflare.html).
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Disabled knowledge base sources:
📝 WalkthroughWalkthroughThe change standardizes Cloudflare Analytics permission wording to ChangesCloudflare permission wording
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai review |
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
|
@coderabbitai summary |
✅ Action performedSummary regeneration triggered. |
The Connect Cloudflare Analytics dialog named its one permission as
Zone · Analytics · Read, while the setup CLIs now write every scope the way the Cloudflare token editor does. The scope chip and the security callout in both locales now readZone → Analytics: Read— the label itself stays in dashboard English inside the Japanese copy, since it names a Cloudflare UI control. The scope-contract test (cf-analytics-scope.test.ts) pins the new form, and the doc comment inapp.d.tsfollows.Mock approved in the Sona design project (
screens/admin/connect-cloudflare.html); the same revision fixed the mock's stale Account-level scope. Tracked on SONA-200.Follows the notation convention established in #390.
Summary by CodeRabbit
Zone → Analytics: Readnotation.