Repository navigation
Fix sbx upgrade compatibility and runner resilience - #57
Merged
Merged
Conversation
Keep the supervisor running through candidate lease-write timeouts while preserving quarantine, exact cleanup, and capacity limits. Make verified sandbox template removal noninteractive and cover recovery with regression tests.
5 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrading Docker Sandboxes from v0.46.0 to v0.49.1 caused
./startto fail on inventory and diagnostics CLI changes introduced in v0.48. Long-running pools could also exit when a host-trust lease write timed out during runner readiness. This PR restores startup compatibility and keeps recoverable candidates within the existing quarantine, exact-cleanup, and capacity rules.The changes are split across seven focused commits. The guest lock check requires a rebuilt local template or a newly published prebuilt package containing it. Live Windows relay validation remains outstanding; the macOS smoke does not certify foreign-architecture workloads or other host platforms.
Validation
Validation was performed across the commits and repeated for affected behavior after corrections:
go test -timeout 5m ./...), affected image/provider/pool/startup normal and race checks, and wrapper syntax/command-forwarding checks passed../startbrought two cached Full-template runners online and idle. Console and guest logs, host-trust lease renewal, and exact shutdown cleanup were checked. A foreign workspace-free sandbox remained untouched by EPAR cleanup.Checklist