feat(eca62): add presigned URL, delete and exists methods to IS3 #609
Merged
Conversation
feat(eca62): add presigned URL, delete and exists methods to IS3
Extend the IS3 storage abstraction with the standard object operations
that were missing for a presigned-URL based workflow, keeping all S3
logic inside the library.
IS3.java:
- getUploadPresignedUrl(ResourceMetadata, contentType, expirationSeconds)
- getDownloadPresignedUrl(ResourceMetadata, expirationSeconds)
- deleteResource(ResourceMetadata)
- exists(ResourceMetadata)
S3.java:
- Implement the four methods over the existing AWS SDK v1 client using
generatePresignedUrl (HttpMethod.PUT/GET), deleteObject and
doesObjectExist, reusing getBucketName() and
ResourceMetadata.getResourceFileName() for the object key.
- contentType is bound to the PUT signature only when provided.
This lets callers sign upload/download URLs so the client transfers
bytes directly to/from S3, while bucket/region/credentials keep being
resolved from the per-client FileHandler (AD_AppRegistration).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(eca62): add presigned URL, delete and exists methods to IS3
Extend the IS3 storage abstraction with the standard object operations
that were missing for a presigned-URL based workflow, keeping all S3
logic inside the library.
IS3.java:
S3.java:
generatePresignedUrl (HttpMethod.PUT/GET), deleteObject and
doesObjectExist, reusing getBucketName() and
ResourceMetadata.getResourceFileName() for the object key.
This lets callers sign upload/download URLs so the client transfers
bytes directly to/from S3, while bucket/region/credentials keep being
resolved from the per-client FileHandler (AD_AppRegistration).