Fix: Prevent extreme zero-output swaps (CWE-382)#11
Open
Sigmabrogz wants to merge 1 commit intosolidquant:mainfrom
Open
Fix: Prevent extreme zero-output swaps (CWE-382)#11Sigmabrogz wants to merge 1 commit intosolidquant:mainfrom
Sigmabrogz wants to merge 1 commit intosolidquant:mainfrom
Conversation
…revent zero-output swaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a basic
amountOutMin >= 1slippage protection to prevent manipulative attacks from sandwiching swaps to output exactly zero tokens. While a dynamic slippage parameter parsed from the payload is recommended for production use, this acts as an initial guard against edge case exploits.