upgrade: share package upgrade for Solid 2.0

.changeset/share-solid2-migration.md

@@ -0,0 +1,14 @@
+---
+"@solid-primitives/share": major
+---
+
+Migrate to Solid.js v2.0 (beta.10)
+
+## Breaking Changes
+
+**Peer dependencies**: `solid-js@^2.0.0-beta.10` and `@solidjs/web@^2.0.0-beta.10` are now required.
+
+### `@solid-primitives/share`
+
+- `isServer` is now imported from `@solidjs/web` (was `solid-js/web`)
+- `createWebShare` — internal `createEffect` converted to the split compute/apply pattern required by Solid 2.0; the `on` helper (removed in Solid 2.0) is no longer used

packages/share/README.md

@@ -152,9 +152,10 @@ import { createWebShare } from "@solid-primitives/share";
 const [data, setData] = createSignal<ShareData>({});
 const shareStatus = createWebShare(data);
 
-createEffect(() => {
-  console.log(shareStatus.status, shareStatus.message);
-});
+createEffect(
+  () => shareStatus.status,
+  status => console.log("Share status:", status, shareStatus.message),
+);
 ```
 
 ## Changelog

packages/share/dev/index.tsx

@@ -1,4 +1,4 @@
-import { type Component, createEffect, createSignal } from "solid-js";
+import { type Component, createSignal } from "solid-js";
 
 import { createWebShare } from "../src/index.js";
 

packages/share/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@solid-primitives/share",
-  "version": "2.2.4",
+  "version": "3.0.0",
   "description": "Primitives to help with sharing content on social media and beyond.",
   "author": "David Di Biase <dave@solidjs.com>",
   "contributors": [
@@ -52,10 +52,12 @@
     "test:ssr": "pnpm run vitest --mode ssr"
   },
   "peerDependencies": {
-    "solid-js": "^1.6.12"
+    "@solidjs/web": "^2.0.0-beta.10",
+    "solid-js": "^2.0.0-beta.10"
   },
   "typesVersions": {},
   "devDependencies": {
-    "solid-js": "^1.9.7"
+    "@solidjs/web": "2.0.0-beta.10",
+    "solid-js": "2.0.0-beta.10"
   }
 }

packages/share/src/social-share.ts

@@ -1,5 +1,5 @@
 import { type Accessor, createSignal } from "solid-js";
-import { isServer } from "solid-js/web";
+import { isServer } from "@solidjs/web";
 import { type Network } from "./networks.js";
 
 export type SharePopupOptions = {

packages/share/src/web-share.ts

@@ -1,5 +1,5 @@
-import { type Accessor, createEffect, createSignal, on, type OnOptions } from "solid-js";
-import { isServer } from "solid-js/web";
+import { type Accessor, createEffect, createSignal } from "solid-js";
+import { isServer } from "@solidjs/web";
 
 /**
  * Generates a simple non-reactive WebShare primitive for sharing.
@@ -67,24 +67,26 @@ export type ShareStatus = {
  */
 export const createWebShare = (
   data: Accessor<ShareData>,
-  deferInitial: boolean = false,
+  deferInitial = false,
 ): ShareStatus => {
   if (isServer) {
     return {};
   }
   const [status, setStatus] = createSignal<ShareStatus>({});
   const share = makeWebShare();
+  let skipFirst = deferInitial;
   createEffect(
-    on(
-      data,
-      dataValue => {
-        setStatus({});
-        share(dataValue)
-          .then(() => setStatus({ status: true }))
-          .catch(e => setStatus({ status: false, message: e.toString() }));
-      },
-      { defer: deferInitial } satisfies OnOptions as any,
-    ),
+    () => data(),
+    dataValue => {
+      if (skipFirst) {
+        skipFirst = false;
+        return;
+      }
+      setStatus({});
+      share(dataValue)
+        .then(() => setStatus({ status: true }))
+        .catch(e => setStatus({ status: false, message: e.toString() }));
+    },
   );
 
   return {