perf(text): single-space fast path in wrapLine + unit tests for #128#130
Merged
Conversation
… for #128 PR #128 made wrapLine measure the real separator string so multi-space runs are counted at their true width, but that added a measureText call per word gap even for the dominant single ' ' case — on the Canvas backend that's a ctx.measureText per gap during layout. Reuse the precomputed spaceWidth when the separator is exactly one space and only measure multi-char runs. Also adds the unit tests #128 landed without: multi-space separators wrap at their real width and are preserved when the line fits, ZWSP runs stay zero-width, and the single-space path uses the precomputed width. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #128 (effective space width in
wrapLine):spaceWidthwhen the separator is exactly one' '— the dominant case — instead of callingmeasureTextper word gap. Multi-char runs (multiple spaces, ZWSP runs) are still measured for real. On the Canvas backend the old code paid actx.measureTextper gap during layout.'aa bb'atmaxWidth: 55wraps into two lines — this was the bug fix(text): improve effective space width calculation in wrapLine function #128 fixed and previously overflowed)spaceWidth(asserted by passing aspaceWidththat differs from the measured value)Why
#128 fixed a real overflow bug but merged without tests (repo rule: unit tests required) and regressed the common single-space case from a constant lookup to a measure call per gap.
Notes for reviewers
overflowandbreakAllwrap strategies still use the raw singlespaceWidthfor the separator, so the multi-space underestimate persists on those paths. Pre-existing, out of scope here.🤖 Generated with Claude Code