feat(vrt): run visual regression on the Canvas2D backend in CI#126
Merged
Conversation
Completes the canvas visual-regression rollout started in #125: - Certify chromium-ci-canvas baselines (151 snapshots), captured in the Docker CI environment. Captured twice and pixel-diffed: both runs byte-identical, guarding against the texture-placeholder timing flake seen once during triage. - Flip the runner's default renderMode from 'webgl' to 'all', as the option's comment anticipated — local runs and CI now cover both backends by default. - Split the CI workflow: unit tests in their own job, visual regression as a webgl/canvas matrix (fail-fast off, per-mode failed-results artifacts) so a red X names the backend that regressed. - Document the dual-backend workflow in visual-regression/README.md and CLAUDE.md, including the per-test renderModes opt-out. Validated with a CI-style Docker compare run over both backends: webgl 180/180 and canvas 151/151 snapshots pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the canvas visual-regression rollout started in #125. CI now tests both rendering backends on every PR.
Certified canvas baselines
chromium-ci-canvassnapshots, captured in the Docker CI environment.Runner default →
allpnpm test:visualnow runs webgl and canvas by default (the option's comment anticipated this flip once baselines existed). Single-backend runs remain available via--renderMode webgl|canvas.CI workflow matrix
renderMode: [webgl, canvas]matrix withfail-fast: false— a failing check names the backend that regressed, and both legs always report.failed-results-webgl/failed-results-canvas), which also fixes the artifact-name collision the matrix would otherwise hit.Docs
visual-regression/README.mdandCLAUDE.mdnow describe the dual-backend workflow: new rendering features need snapshots for both backends, or arenderModes = ['webgl']export with a stated reason.Verification
CI-style Docker compare run (
RUNTIME_ENV=ci, defaultallmode) over the committed baselines:🤖 Generated with Claude Code