Skip to content

refactor(Android, Stack v5): separate React and native domains in header implementation #4150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kligarski wants to merge 10 commits into
base: @kligarski/stack-v5-android-update-back-button
Choose a base branch
from
+1,107 −1,112
Draft

refactor(Android, Stack v5): separate React and native domains in header implementation #4150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
708fbb4
first version
kligarski Jun 10, 2026
9e732c6
fix crash
kligarski Jun 10, 2026
03d2197
fix redundant update
kligarski Jun 10, 2026
4e9aa98
rename
kligarski Jun 10, 2026
7bca17b
remove shadow state update from subview providing; rename callbacks t…
kligarski Jun 10, 2026
1a7851b
small cleanup
kligarski Jun 10, 2026
b8effac
remove StackHost from UIManagerEventListeners on teardown
kligarski Jun 10, 2026
798a5eb
clean up 2
kligarski Jun 10, 2026
d0dc4aa
fix no header on first render bug
kligarski Jun 10, 2026
e927adc
format Android
kligarski Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions android/src/main/java/com/swmansion/rnscreens/gamma/stack/header/StackHeaderAppBarLayout.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import android.annotation.SuppressLint
import android.content.Context
import android.view.ViewGroup.LayoutParams.MATCH_PARENT
import android.view.ViewGroup.LayoutParams.WRAP_CONTENT
import androidx.appcompat.widget.AppCompatTextView
import androidx.coordinatorlayout.widget.CoordinatorLayout
import com.google.android.material.R
import com.google.android.material.appbar.AppBarLayout
Expand Down Expand Up @@ -42,6 +43,9 @@ internal sealed class StackHeaderAppBarLayout(
layoutParams = LayoutParams(MATCH_PARENT, WRAP_CONTENT)
}

// We need to manually manage the title to handle leading subview's positioning.
internal var managedTitleView: AppCompatTextView? = null

init {
addView(toolbar)
}
Expand Down
Loading
Loading