Skip to content

feat(ios): add subtitle support for UIMenu header button submenus #4107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreavrr wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −5
Open

feat(ios): add subtitle support for UIMenu header button submenus #4107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions ios/RNSBarButtonItem.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,16 @@ + (UIMenu *)initUIMenuWithDict:(NSDictionary<NSString *, id> *)dict
image = img;
}];

return [UIMenu menuWithTitle:dict[@"title"]
image:image
identifier:nil
options:RNSMakeUIMenuOptionsFromConfig(dict)
children:elements];
UIMenu *menu = [UIMenu menuWithTitle:dict[@"title"]
image:image
identifier:nil
options:RNSMakeUIMenuOptionsFromConfig(dict)
children:elements];
NSString *subtitle = dict[@"subtitle"];
if (subtitle != nil && @available(iOS 15.0, *)) {
menu.subtitle = subtitle;
}
return menu;
}

+ (UIAction *)createActionItemFromConfig:(NSDictionary *)dict
Expand Down
1 change: 1 addition & 0 deletions src/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,6 +1251,7 @@ export interface HeaderBarButtonItemMenuAction {
export interface HeaderBarButtonItemSubmenu {
type: 'submenu';
title?: string | undefined;
subtitle?: string | undefined;
icon?: PlatformIconIOS | undefined;
items: HeaderBarButtonItemWithMenu['menu']['items'];
displayInline?: boolean | undefined;
Expand Down