fix(worklets): compile JSX in generated worklet files#9610
Open
hannojg wants to merge 1 commit into
Open
Conversation
3573ed2 to
8d0e273
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes and enables JSX usage in worklets:
Background:
Imagine you have
then metro transforms our app code. In dev, React Native’s Babel preset includes JSX dev handling, which annotates JSX with debug metadata:
Now, the worklets plugin captures this and writes it into the generated worklet file.
As we created a new file, Metro later processes that generated
.worklets/<hash>.jsfile too.Here, Babel’s JSX dev transform sees JSX that already has
__selfand throws while trying to apply dev JSX handling again with the error described in #9214!What I changed:
I basically configured the worklets babel plugin that writes the .worklets/.js
files to use@babel/preset-react`.This way:
would become:
now, when metro processes the file, it would not try to transform the JSX and insert __self, as its already transformed.
I am not sure if this is an actual fix or rather a workaround.
Test plan
Added a test file!