feat: web support for CSS animation callbacks#9605
Open
MatiPl01 wants to merge 1 commit into
Open
Conversation
Mirror the web CSS transition callbacks for animations: onAnimationStart, onAnimationEnd, onAnimationIteration and onAnimationCancel, declared in style and delivered from the DOM AnimationEvent with an { animationName, elapsedTime } payload. Warn in __DEV__ when animation callbacks are set without any animation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CSS animation event callbacks on web:
onAnimationStart,onAnimationEnd,onAnimationIteration,onAnimationCancel, declared instylealongside the animation config. On web they map directly to the browser's native DOM animation events (zero JSI), scoped per-view: animation events bubble, so descendant animations are ignored, matching native's per-view model. The callback payload is{ animationName, elapsedTime }.Also warns in
__DEV__when animation callbacks are provided without any animation configured.Native (iOS/Android) support is a follow-up.
Test plan
CSSManager: all four events deliver the correct{ animationName, elapsedTime }, bubbling is scoped to the view, a negativeanimationDelaystarts the animation mid-way (animationstartwithelapsedTime == |delay|), and the animation longhands (delay, iteration-count, play-state) are written and cleared correctly.