Repository navigation
fix: fall back to defaults for options passed as undefined - #1612
Merged
Merged
Conversation
normalize, VAD detectVoice and chat session per-turn config merged options with an object spread, so an undefined field replaced its default.
barhanc
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Same bug as #1610 in three more places: an option passed as
undefinedreplaced its default.normalize: native throwsINVALID_ARGUMENT.detectVoice: thresholds becomeNaN, silently returns no segments.genConfig: drops the session default (e.g.maxNewTokensbecomes unlimited).Introduces a breaking change?
Type of change
Tested on
Testing instructions
yarn workspace react-native-executorch test __tests__/extensions/normalize.test.ts __tests__/tasks/remainingTasks.test.ts __tests__/tasks/llmChatSession.test.tssrc/changes.Screenshots
Related issues
#1610, sampler part fixed in #1611.
Checklist
Additional notes