Repository navigation
chore: Phonemis Build changes after Verbalis migration - #1604
Merged
Merged
Conversation
Phonemis now preprocesses text with Verbalis, a nested submodule in third-party/verbalis. The podspec takes Phonemis's sources and header search paths from its phonemis_sources.rb, so they include Verbalis and follow Phonemis's layout. CI and the third-party README check the submodule out recursively; Android needs no change, since Phonemis's CMake builds Verbalis from the submodule. The submodule URL follows Phonemis's move to software-mansion-labs. Phonemis now includes <optional> and <string> where it uses them, so the host tests no longer force-include them for libstdc++.
msluszniak
reviewed
Nov 3, 2026
msluszniak
left a comment
Member
There was a problem hiding this comment.
Also outside the diff:
compile_flags.txtneeds-isystemthird-party/common/phonemis/third-party/verbalis/cpp/include:phonemizer.hnow reaches<verbalis/verbalizer.h>viapipeline.h, so clang-tidy/clangd can't parse it.- Root
LICENSE: add Verbalis (MIT) to the third-party components; cn2an code moved there from Phonemis. cpp/tests/README.md:65still lacks--recursive.
- compile_flags.txt: add Verbalis's include path, so clangd and clang-tidy parse the speech sources, which reach <verbalis/verbalizer.h> through Phonemis's headers. - clang-tidy.yml: check out only Phonemis and Verbalis, as ci.yml does, instead of every submodule. - ci.yml: check out Phonemis in the TypeScript API tests job, since the podspec they evaluate requires phonemis_sources.rb. - create-package.sh: pack only Verbalis's cpp/ and license files. - LICENSE: list Verbalis (MIT), which bundles the cn2an port. - cpp/tests/README.md: check out Phonemis recursively.
…ckage Phonemis main has the merged Verbalis work, and notices that credit Verbalis. create-package.sh also leaves out Phonemis's README image and README source, and restores the whole submodule after packing.
Member
|
Please bump phonemis to |
Contributor
Author
|
I think you wrote that before the commit landed :-p Done in 2b6849f: phonemis is at 5ec260e (v0.4.0), so its THIRD_PARTY_NOTICES.md now lists Verbalis. create-package.sh also trims readme.source.md and assets/, and the restore step now restores the whole submodule. |
benITo47
marked this pull request as ready for review
November 4, 2026 13:32
msluszniak
self-requested a review
November 4, 2026 13:33
PhonemizerOutputTest runs the en-us pipeline on the shipped tagger and lexicon, fetched as fixtures, and pins the phonemes and word locations for numbers, money, dates, abbreviations, times and units.
PhonemizerOutputTest adds en-gb and zh on their shipped data. PreprocessingTest pins what phonemis feeds the neural model for de, fr, es, it, pl, pt and hi. Known misreadings point at Verbalis#8.
A phonemis or Verbalis bump that changes a reading now fails with the old and new value and is accepted with RNE_UPDATE_SNAPSHOTS=1, so the PR shows the diff. LeavesNoDigitsOrSymbols and LocatesEveryWordOfTheInput hold across versions and catch real regressions.
msluszniak
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phonemis now preprocesses text (numbers, dates, symbols, abbreviations) with Verbalis 0.1.1, a nested submodule in
third-party/common/phonemis/third-party/verbalis. This PR moves the Phonemis submodule to that version and makes the build pick Verbalis up:phonemis_sources.rb, which Phonemis now ships.ci.yml,clang-tidy.yml) andthird-party/README.mdinitialize the Phonemis submodule recursively.software-mansion-labs/Phonemis, where Phonemis moved.Tested
apps/speechsimulator build succeeds; 23 Verbalis and 19 Phonemis sources compile, and the app links.apps/speechdebug APK builds;run-native-tests.sh): 195 / 195 pass, includingPhonemizerTest16 / 16.Blast Radius: speech.
git submodule update --init --recursive. Without the nested submodule, Android's CMake downloads Verbalis and the iOS podspec can't find it