Skip to content

fix(ios): reset extendUnderStatusBar on recycle #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giaBaoJS wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ios): reset extendUnderStatusBar on recycle #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ios/BottomSheetComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,9 @@ - (void)prepareForRecycle
[self restoreInlinePresentation];
_needsIndexSyncAfterRecycle = YES;
[_sheetView resetSheetState];
// `_extendUnderStatusBar` is the diff baseline for the prop, so the hosting
// view has to be reset with it or a recycled sheet keeps the previous flag.
[_sheetView setExtendUnderStatusBar:NO];
_sheetState.reset();
_lastContentOffsetY = 0;
_lastGeometryFrameSize = CGSizeZero;
Expand Down