Repository navigation
feat: voice quality ports (Skip cleanup, mic test, filler removal, Silero VAD) - #87
Merged
Merged
Conversation
Skip silence and Remove filler words are not language choices. The microphone test's playback track now fills the strip so Close sits at its trailing edge.
Removed fillers now go as one group with their own punctuation, and the seam keeps only what the surviving clause needs: a terminal closes the clause before it, a comma that only introduced the filler is dropped. Inline code, quoted and bracketed mentions are left alone.
A comma before a filler stays even at a line end, so letter salutations survive. Recapitalization skips code, numbers and names with their own casing. Code spans pair backtick runs of equal length and are found once per pass, which also makes long transcripts linear. A long dash before a digit is kept as a possible minus sign.
Fillers quoted with corner brackets or full-width parentheses are mentions and stay. Recapitalization leaves addresses, domains and paths as written, and a long dash before a decimal point is kept as a sign.
Swap the meter and the processing label in sequence instead of cross-fading them on top of each other, hold the processing silhouette through the finish so the meter cannot flash under the delivered check, and never return to "Transcribing" once the pill has read "Polishing". Skip becomes a capsule nested in the pill's trailing end. The label, the chip and the capsule's width now follow one eased value, and the hover hint fades out with its last words instead of vanishing.
A healthy server finishes cleanup in 170 ms to 1 s, so the label and the Skip chip flashed past on every Dictation. The pill now names itself "Polishing" only after 400 ms of cleanup and offers Skip after 1.5 s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four dictation-quality features, plus pill polish tuned against real server timings.
Pill pacing during cleanup, measured against the live ASR + cleanup servers:
New dev hook:
WHISPER_DEV_SCENE=pill:flowloops one whole dictation;WHISPER_DEV_FLOW_MS=<transcribe>,<cleanup>replays any server speed (seedocs/testing.md).Evidence
After: short dictations go recording → Transcribing → check; Polishing appears only past 400 ms, Skip only past 1.5 s.
scripts/check.sh: 648 passed, 0 failed, 14 ignored (hardware).fast_cleanup_never_shows_its_label_or_skip,swapped_layers_never_overlap_at_full_strength,processing_layout_centers_the_label_and_docks_the_skip_chip, plus VAD fixtures (tests/fixtures/vad-*.json|wav) and filler-word cases.Merge Danger
Door: two-way
Revert restores the previous pipeline; settings additions are additive.
Blast Radius: dictation
VAD and filler removal change what text every dictation delivers; a mis-trimmed segment or over-eager filler edit would show up as missing words. Adds a ~1.3 MB ONNX model to the binary.