Skip to content

fix: synchronize provider tab selection with menu card - #74

Merged
softmaxe merged 1 commit into
mainfrom
t3/fix-claude-status-bar-switch
Nov 11, 2026
Merged

softmaxe merged 1 commit into
mainfrom
t3/fix-claude-status-bar-switch

Conversation

@softmaxe

Copy link
Copy Markdown
Owner

Summary

Keep the selected tab and provider content synchronized when switching providers during the refresh cooldown. Use the provider delivered by @Published instead of rereading the setting before willSet completes.

 onProviderPublished(provider)
-  selectTab(settings.menuBarProvider)
+  selectTab(provider)
   renderCard(provider)

Evidence

  • Before: The regression test fails on the original controller with the card kept the Codex tab after Claude was clicked.
    After: make test passes all 1758 checks, including immediate Codex → Claude selection and Pi → Codex selection while refreshes are in cooldown.

Merge Danger

Door: two-way

The controller change can be reverted without a migration.

Blast Radius: menu

Affects provider tab selection in the open menu card.

@softmaxe
softmaxe enabled auto-merge (squash) November 11, 2026 16:27
@softmaxe
softmaxe merged commit f8df98b into main Nov 11, 2026
8 checks passed
@softmaxe
softmaxe deleted the t3/fix-claude-status-bar-switch branch November 11, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant