Repository navigation
refactor: remove code with no effect on macOS - #14
Merged
Merged
Conversation
hidapi's macOS backend ignores the blocking flag in read_timeout and reports a successful write at full length, so neither path can change behavior on the only supported platform.
GBAT_BINARY is the only override, and the script no longer looks for a binary in the repository root, where no build or install puts one. BREAKING CHANGE: GPWBAT_BINARY and GPW2_BATTERY_BINARY are ignored.
VHS 0.12.1 renders and replaces the GIF itself, so the FFmpeg pipeline that worked around 0.12.0 is no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove code that no longer changes behavior on macOS, the only supported platform.
docs/record-demo.sh rewrite the tape's Output to a temporary GIF vhs - ffmpeg frame merge and filter graph # VHS 0.12.0 workaround ffmpeg decode check replace assets/demo.gifEvidence
cargo test --locked: 26 passed.Battery: 75%from the installedgbat0.0.1.After:
cargo fmt --checkandcargo clippy --all-targets --locked -- -D warningspass.cargo test --locked: 26 passed. The new release build printsBattery: 75%from a real mouse and exits 0.GPWBAT_BINARY=<stub>selected the stub.After:
GBAT_BINARY=<stub>selects the stub.GPWBAT_BINARY=<stub>is ignored and the script usesgbatfromPATH.demo.tapewent through the frame export and FFmpeg pipeline.After: VHS 0.12.1 alone renders the real
demo.tapefrom a real mouse to a valid 1100x500, 324-frame GIF. A separate small tape confirmed it replaces an existing file.docs/record-demo.shitself was not run, soassets/demo.gifis unchanged.Merge Danger
Door: two-way
Each change is a plain revert.
Blast Radius: small
Anyone still setting
GPWBAT_BINARYorGPW2_BATTERY_BINARY, or keeping a binary at the repository root, falls through to the normal search after updating the Raycast script. Recording the demo now needs VHS 0.12.1 or later. A futurehidapiupgrade that allows partial writes would no longer be detected.