Skip to content

ci: simplify CI and release workflows - #8

Merged
softmaxe merged 5 commits into
mainfrom
ci/simplify-workflows
Oct 15, 2026
Merged

softmaxe merged 5 commits into
mainfrom
ci/simplify-workflows

Conversation

@softmaxe

Copy link
Copy Markdown
Owner

Summary

CI runs one job per pull request; checks that ran only at release time now run in make test.

 ci.yml (on: pull_request)
-  push: main                       # retested the same tree after squash merge
-  changes (ubuntu)                 # docs-only filter via gh api
   Build and test (macos-26)
     make all test
       tests/cli.sh
+      tests/binary.sh build/ferry $(ARCH) $(MACOS_MIN)   # arch, minos, AppKit

 release.yml
   build
     make all test
-    lipo / otool / --version checks   # now in make test
     package
   formula-test
     brew audit / install / test
-    lipo check                       # same sha256-pinned archive as build
   tap-sync
-    git status / staged-path / --check assertions   # fresh checkout, one file staged

 dependabot.yml
+  cooldown: 7 days

ARCH and MACOS_MIN are now Makefile variables, so the compiler flags and the test read one value.

Evidence

  • Before: an -arch or -mmacosx-version-min regression fails only in the release workflow, after the tag is pushed.
    After: make test fails on the pull request:

    $ CFLAGS="-O2 -Werror" make all test
    tests/binary.sh build/ferry arm64 26.0
    ok: architecture
    ok: minimum macOS
    ok: links AppKit
    
    $ tests/binary.sh build/ferry x86_64 15.0
    FAIL: architecture: expected x86_64, got arm64
    FAIL: minimum macOS: expected 15.0, got 26.0
    2 test(s) failed     # exit 1
    
  • actionlint and shellcheck tests/binary.sh pass. The release workflow changes are only checked statically until the next tag.

Merge Danger

Door: two-way

Revert restores every removed step. Build and test keeps its name, so the required check still matches.

Blast Radius: release

A mistake in release.yml shows up on the next v*.*.* tag. Tags are immutable, so a failed release means fixing forward and releasing the next patch version.

main only accepts squash merges of up-to-date branches, so the push run on
main retested the same tree. Without it, the docs-only change filter no
longer saves anything worth its extra job, so Build and test always runs.
The architecture, deployment target, and AppKit checks ran only in the
release workflow, so a regression surfaced at tag time. make test now runs
them on every pull request, and the release workflow relies on it.
The tap is a fresh checkout and only Formula/ferry.rb is staged, so the
working tree and staged path assertions always passed.
@softmaxe
softmaxe enabled auto-merge (squash) October 15, 2026 06:06
@softmaxe
softmaxe merged commit 004c19c into main Oct 15, 2026
3 checks passed
@softmaxe
softmaxe deleted the ci/simplify-workflows branch October 15, 2026 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant