Skip to content

chore: remove demo video and README videos - #5

Merged
softmaxe merged 2 commits into
mainfrom
claude/remove-animation-readme-video-183829
Oct 13, 2026
Merged

softmaxe merged 2 commits into
mainfrom
claude/remove-animation-readme-video-183829

Conversation

@softmaxe

Copy link
Copy Markdown
Owner

Summary

Drop the demo video and everything that only existed to build or show it.

 .github/workflows/ci.yml
   changes            # path filter no longer emits `demo`
   check              # Build and test, unchanged
-  demo               # Node typecheck + tests for demo/
-demo/                # Remotion short, score, scripts
 GLOSSARY.md
-  ## Demo video      # Trip, Arrival, Landing
 README.md / README.zh-CN.md
-  user-attachments video link

Evidence

  • Before: grep -rn demo lists demo/, the CI demo job, and the glossary section; both READMEs embed a video.
    After: grep -rn demo --exclude-dir=.git returns 0 lines; make all test passes.

Merge Danger

Door: two-way

Reverting this PR restores demo/ and the video links; the uploaded videos stay on GitHub.

Blast Radius: docs

READMEs lose the video; the binary, Raycast scripts, and release workflow are untouched.

@softmaxe
softmaxe enabled auto-merge (squash) October 13, 2026 10:47
@softmaxe
softmaxe merged commit aab9343 into main Oct 13, 2026
4 checks passed
@softmaxe
softmaxe deleted the claude/remove-animation-readme-video-183829 branch October 13, 2026 10:48
softmaxe added a commit that referenced this pull request Oct 15, 2026
## Summary

Maintenance pass looking for unnecessary tests and code that is hard to
maintain long-term. The repo is already lean (the demo was removed in
#5), so the changes are small:

- **raycast/** — each of the five scripts carried the same 20-line
binary lookup (an `if/elif` chain plus a `for` loop over candidates). It
is replaced with `path+=(...)` + `whence -p ferry`, so each script drops
from 39 to 24 lines. Scripts stay self-contained so the README's "copy
the five files" / "copy a script for Space 6+" workflow still works.
Lookup order is unchanged: `FERRY_BINARY` → inherited `PATH` →
`/opt/homebrew/bin` → `/usr/local/bin` → `~/.local/bin` → `build/` next
to `raycast/`. The missing-binary message and exit status 127 are
unchanged.
- **src/ferry.m** — `g_verbose` was a file-scope global used only inside
`main`; it is now a local.
- **tests/follow.m** — names the fullscreen space type
(`SPACE_TYPE_FULLSCREEN`) instead of using the literal `4` twice,
matching `ferry.m`.

## Reviewed and kept

- `tests/cli.sh`: each case covers a distinct argument-parsing branch
(non-numeric, zero, overflow, missing value, unknown option, extra
index). None are redundant.
- `tests/follow.m`: manual-only, but it is the only test of real move
and Follow behavior (the issue #2 regression).
- `macho_find_symbol` and the focus code mirror yabai and stay as they
are, per AGENTS.md "upstream first".

## Test plan

- Ran a Raycast script under zsh with stub binaries for each lookup
case: nothing found (exit 127 + message), `build/` fallback,
`~/.local/bin` beating `build/`, `PATH` beating fallbacks,
`FERRY_BINARY` winning, a missing `FERRY_BINARY` erroring, and
invocation from another cwd. All match the old order.
- The `.m` changes could not be compiled locally (Linux container). CI
builds them on macOS 26 with `-Werror`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01P1i79aMaG5M7eTyaXZuVS9

---
_Generated by [Claude
Code](https://claude.ai/code/session_01P1i79aMaG5M7eTyaXZuVS9)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant