Repository navigation
Fix 31 runtime/documentation divergences found by a bidirectional audit #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
b20e9f7
fix(monitor): look for the plugin where horus install puts it
starswallow 6640fda
fix(control): make horus node restart actually restart the node
starswallow 3028b02
fix(safety): count consecutive deadline misses, not budget overruns
starswallow 88688dc
fix(safety): make the max_deadline_misses emergency stop reachable
starswallow 51ade03
fix(run): apply [network] on every path that spawns a run child
starswallow 01d5939
fix(log): HORUS_LOG_FILE actually starts the file drain
starswallow ff8239f
fix(topic): try_send and send_blocking move the staleness counter
starswallow 8c87bf3
fix(topic): tell the 17th participant why it has no comms
starswallow dbd4d94
fix(python): a refusal for want of backpressure is not a timeout
starswallow f557cdd
fix(python): make subs= type auto-detection actually run
starswallow 5770e6e
fix(cli): three flags that did not do what they said
starswallow 8de0220
test(log): fix a race in the drain wiring test that CI caught
starswallow 6e1d7a0
fix(topic): give a participant registration back when its handle drops
starswallow d0fa1df
fix(topic): stop advertising a migration drain that is not performed
starswallow c4f981b
fix(rt): a safing callback that panics must not cancel the safety action
starswallow d5b507c
fix: a watchdog is never tightened, and topic metrics count real traffic
starswallow 65f461a
fix(launch): --status told the truth about nothing, and namespace: li…
starswallow a92dc95
fix(python): an untyped topic accepts a message object, and the quick…
starswallow 69a80b9
fix(drivers): honour `simulated`, and name an exec driver after its e…
starswallow c556dac
fix(cpp): a param value must not come back silently clipped
starswallow 5f568ab
fix(install): a prefix install must export the variable it depends on
starswallow c9b7096
merge: origin/main into fix/docs-runtime-divergence
starswallow e09c9fa
merge: drop the duplicated monitor lookup, keep main's
starswallow fa4a59a
merge: origin/main (#192, #193) into fix/docs-runtime-divergence
starswallow cf6b35b
test(cpp): cover the get_string re-call, which nothing exercised
starswallow 69a6b3b
test(topic): stress the participant release under concurrent churn
starswallow f97a5e2
fix(topic): count a handle taking a role its sibling already holds
starswallow 84d2dec
test(monitor): pin the opt-in on the project-local plugin lookup
starswallow 8264221
fix(tests): stop leaking a shared-memory namespace per isolated child
starswallow 4fde12f
fix(topic): pool-backed try_send moves the staleness counter too
starswallow a9ca7d9
fix(control): horus node restart must reach a node on an executor
starswallow ca021a0
test: three of this branch's own guards did not guard
starswallow 8fc089f
test: anchor the safing-order guard on code, not on a comment
starswallow 316dc0f
fix: three more defects in this branch's own work
starswallow 3162491
fix: an error that asked for the impossible, and a stale doc-comment
starswallow cf23bb6
fix: three more declared-but-not-delivered defects
starswallow e6e9681
revert: restore four files the previous commit truncated
starswallow 0609bb1
fix: two hints that could never fire, and a preferred section nobody …
starswallow b9841bd
fix: --sim did nothing at all on the Python driver path
starswallow 4982855
fix(python): a Python doc example was compiled as Rust
starswallow ba88c7e
fix(install): the stale-prefix removal used a GNU-only regex
starswallow a4ee330
fix: a C++ log line reached horus log with no time on it
starswallow 4725035
fix(install): the Rust version gate failed closed when it could not c…
starswallow d6fdf1c
fix: scheduler introspection invented answers while the scheduler ran
starswallow d42d532
fix: safing diagnostics were queued with nothing to drain them
starswallow 7867ad2
fix(uninstall): the HORUS_PREFIX export survived the uninstall
starswallow 94e5560
fix(uninstall): a prefix install's PATH line outlived the uninstall
starswallow b3cc642
fix(uninstall): the fish prefix cleanup reported removals it never made
starswallow 7de6fc5
Merge origin/main into fix/docs-runtime-divergence
starswallow 3b1ffa3
fix: horus node pause did nothing to three of the four node classes
starswallow 386e401
fix: nothing ever called the warning that .no_alloc() is unenforced
starswallow c2334ca
fix: the blackbox never recorded a single network event
starswallow 9c7b4ac
test: exempt the compute-diag child switch from the env-var doc guard
starswallow 9764e2b
fix(scheduling): three of the four executors dropped their last diagn…
starswallow 8f25e79
fix: replay lost the recorded node order, and two docs contradicted t…
starswallow 1a5af5e
fix: three more places the code did not do what its own file says
starswallow e09a635
fix(scheduling): a diagnostic being written when a drain ran was lost…
starswallow aacebb2
Merge commit '1a5af5ef15a74f1de0ae279920257928d117e486' into merge/ma…
starswallow 31e292b
fix: nine findings from the review, one of which could delete a user'…
starswallow f725ec9
docs(scheduler): the restart path clears two different pauses, not one
starswallow 1e5297b
Merge main (#203, the jitter budget) into fix/docs-runtime-divergence
starswallow fd22aea
Merge remote-tracking branch 'origin/main' into fix/189-review-followups
starswallow 27a032f
ci: pin the documentation half of this audit alongside the code half
starswallow 6fa2268
fix(uninstall): my own guard broke the one case the guard is about
starswallow f5499e6
fix(py): declare peek_topic_type in the stubs, and make the error run…
starswallow File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.