Skip to content

Potential fixes for 2 code quality findings #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
armanist merged 3 commits into from
Apr 3, 2026
Merged

Potential fixes for 2 code quality findings #184

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf9ff51
Apply suggested fix to shared/Transformers/PostTransformer.php from C…
armanist Apr 3, 2026
92ceba2
Apply suggested fix to shared/Transformers/PostTransformer.php from C…
armanist Apr 3, 2026
9fc8925
Change parameter type from object to mixed in transform
armanist Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions shared/Transformers/PostTransformer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class PostTransformer implements TransformerInterface
{
/**
* Transforms the post data
* @param $item
* @param mixed $item
* @return array
*/
public function transform($item): array
Expand All @@ -35,9 +35,24 @@ public function transform($item): array
'uuid' => $item->uuid,
'title' => $item->title,
'content' => markdown_to_html($item->content, true),
'image' => $item->image && $item->user_directory ? $item->user_directory . '/' . $item->image : null,
'image' => $this->buildImagePath($item),
'date' => date('Y/m/d H:i', strtotime($item->updated_at)),
'author' => $item->firstname . ' ' . $item->lastname,
];
}

/**
* Builds the image path for the given item.
*
* @param $item
* @return string|null
*/
private function buildImagePath($item): ?string
{
if ($item->image && $item->user_directory) {
return $item->user_directory . '/' . $item->image;
}

return null;
}
}
Loading